8000 added controller data provider reference to the controller by StephenHodgson · Pull Request #505 · XRTK/com.xrtk.core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Aug 11, 2024. It is now read-only.

added controller data provider reference to the controller #505

Merged
merged 5 commits into from
Apr 7, 2020
Merged

added controller data provider reference to the controller #505

merged 5 commits into from
Apr 7, 2020

Conversation

StephenHodgson
Copy link
Contributor
@StephenHodgson StephenHodgson commented Apr 7, 2020 •
edited
Loading

XRTK - Mixed Reality Toolkit Change Request

Overview

Broke out the controller changes form the hand tracking PR

Target of the change:

Is this enhancement for:

  • Core (core framework, interfaces and definitions)

Breaking Changes:

  • Updated the constructors on all controllers to include the IMixedRealityControllerDataProvideder as a parameter.
  • Added IMixedRealityController.ControllerDataProvider
  • Added IMixedRealityController.AngularVelocity
  • Added IMixedRealityController.Velocity

@StephenHodgson StephenHodgson added Breaking Change Enhancement New feature or request In Progress PR currently still being developed labels Apr 7, 2020
@StephenHodgson StephenHodgson added Ready for review PR finished primary development, open for review and removed In Progress PR currently still being developed labels Apr 7, 2020
@StephenHodgson StephenHodgson merged commit 3b56942 into development Apr 7, 2020
@StephenHodgson StephenHodgson deleted the dev/add-data-provider-reference-to-controllers branch April 7, 2020 07:24
This was referenced Apr 7, 2020
Merged
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@FejZa FejZa FejZa approved these changes

@SimonDarksideJ SimonDarksideJ Awaiting requested review from SimonDarksideJ

Assignees
No one assigned
Labels
Breaking Change Enhancement New feature or request Ready for review PR finished primary development, open for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@StephenHodgson @FejZa
0