This repository was archived by the owner on Aug 11, 2024. It is now read-only.
Fix endless configure toolkit dialog issue #593
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's not fixed it seems. Let me take another look. My first test passed but now it's back sometimes. |
|
Now it's ready |
XRTK-Core/Packages/com.xrtk.core/Editor/Profiles/MixedRealityToolkitRootProfileInspector.cs
Show resolved
Hide resolved
StephenHodgson
approved these changes
May 18, 2020
XRTK-Build-Bot
pushed a commit
that referenced
this pull request
Dec 25, 2020
* Fix endless configure toolkit dialog issue * Fix prompt
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XRTK - Mixed Reality Toolkit Pull Request
Overview
Fixes an issue where the "There is no active Mixed Reality Toolkit in your scene! Would you like to create one now?" dialog endlessly blocks the editor when pressing "Later".
To observe the error in dev open a scene without the Toolkit in it, e.g. some scene you want to load in additively when running. While in that scene select the MixedRealityToolkitRootProfile asset. The dialog shows up. Press later, press later, press later, press later...
Changes
Clear selection for one frame if the user answers "Later". That will make sure Unity does not trigger the
OnEnableevent right away again after selectin "Later".