8000 cleaned up base service by StephenHodgson · Pull Request #423 · XRTK/com.xrtk.core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Aug 11, 2024. It is now read-only.

cleaned up base service #423

Merged
merged 4 commits into from
Dec 28, 2019

Conversation

StephenHodgson
Copy link
Contributor

XRTK - Mixed Reality Toolkit Change Request

Overview

Added some docs and removed some trailing spaces.

@StephenHodgson StephenHodgson added the Ready for review PR finished primary development, open for review label Dec 22, 2019
@SimonDarksideJ
Copy link
Contributor

This is including a submodule change, should only be done once the new 144 update is merged and then retargetted

@StephenHodgson
Copy link
Contributor Author

@SimonDarksideJ right this was to test to validate that it was the Oculus submodule that was causing the builds to fail.

@SimonDarksideJ
Copy link
Contributor
SimonDarksideJ commented Dec 23, 2019

Needs updating to the latest development branch commit @StephenHodgson

@SimonDarksideJ SimonDarksideJ removed the Ready for review PR finished primary development, open for review label Dec 23, 2019
@StephenHodgson StephenHodgson added the Ready for review PR finished primary development, open for review label Dec 27, 2019
@StephenHodgson StephenHodgson merged commit 8812beb into development Dec 28, 2019
@StephenHodgson StephenHodgson deleted the fix/base-service-formatting-and-docs branch December 28, 2019 16:58
XRTK-Build-Bot pushed a commit that referenced this pull request Dec 30, 2019
* cleaned up base service

* rolled back oculus checkout to test if it's the cause of the builds failing

* updated oculus checkout
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Ready for review PR finished primary development, open for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0