This repository was archived by the owner on Aug 11, 2024. It is now read-only.
8000
StephenHodgson
added
the
Ready for review
PR finished primary development, open for review
label
Nov 5, 2019
StephenHodgson
added
In Progress
PR currently still being developed
and removed
Ready for review
PR finished primary development, open for review
labels
Nov 5, 2019
StephenHodgson
added
Ready for review
PR finished primary development, open for review
and removed
In Progress
PR currently still being developed
labels
Nov 6, 2019
StephenHodgson
added
In Progress
PR currently still being developed
and removed
Ready for review
PR finished primary development, open for review
labels
Nov 6, 2019
StephenHodgson
added
Ready for review
PR finished primary development, open for review
Breaking Change
and removed
In Progress
PR currently still being developed
labels
Nov 6, 2019
StephenHodgson
changed the title
Fixed new camera rig setup errors when shutting down
Fixed a few things with the new camera rig
Nov 6, 2019
StephenHodgson
added
In Progress
PR currently still being developed
and removed
Ready for review
PR finished primary development, open for review
labels
Nov 7, 2019
StephenHodgson
added
Ready for review
PR finished primary development, open for review
and removed
In Progress
PR currently still being developed
labels
Nov 9, 2019
Fixed a few things with the new camera rig #405
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed component casting check to ensure we're not trying to destroy components that aren't a IMixedRealityCameraRig type
SimonDarksideJ
previously approved these changes
Nov 5, 2019
SimonDarksideJ
previously approved these changes
Nov 6, 2019
StephenHodgson
commented
Nov 6, 2019
XRTK-Core/Packages/com.xrtk.core/Services/CameraSystem/MixedRealityCameraSystem.cs
Show resolved
Hide resolved
|
@SimonDarksideJ tested this on WMR but Open VR and Oculus still need to be tested. |
|
Sadly, utter fail, for all the same reasons we attached everything to the Body. Altering the headpose, does not alter all the things you want to "synchonise" with the head, e.g. Controllers, Teleportation, gaze, etc. |
|
Gonna close this for now. Yeah we def shouldn't be changing the playspace transform. We expect that anyone will move that to re-position their players. This would def break in that scenario |
added in more documentation updated rig transfrom added in rig transform reset
|
SO before we can merge this, we need to address the height set by platform (or manually) issue. Else we are regressing what is currently in public |
|
Agreed. |
|
Oculus PR unblocked and tested working with this new setup. Good to go. |
SimonDarksideJ
previously approved these changes
Nov 9, 2019
|
I'm gonna hold off on merging this until the submodules get their release |
|
Should be ready now |
SimonDarksideJ
approved these changes
Nov 9, 2019
XRTK-Build-Bot
pushed a commit
that referenced
this pull request
Nov 9, 2019
* Added flags to check if app was quitting before setting up objects Fixed component casting check to ensure we're not trying to destroy components that aren't a IMixedRealityCameraRig type * better camera cleanup * return a null camera if we're shutting down * reverted some changes to how we're syncing the body/playspace transforms * Added an assert for verification * sync the body's x/z position with the camera * add comment * Added back in the body rotation modifications * updated SDK checkout * added in inspector options for camera profile and fixed missing serialization attribute * updated sdk checkout * reverted a few things and made sure we're not manipulating the playspace added in more documentation updated rig transfrom added in rig transform reset * Added some null checks for when camera system isn't enabled * updated oculus checkout * updated submodules * updated all the submodules
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XRTK - Mixed Reality Toolkit Change Request
Overview
Fixed the errors from the camera rig shutting down improperly and syncing the playspace and bodypace transforms correctly.
Mainly we wanna ensure that the body is roughly the same position/rotation of the head (within the adjustment angle threshold)
Target of the change:
Is this enhancement for:
Changes:
Brief list of the targeted features that are being changed.