This repository was archived by the owner on Aug 11, 2024. It is now read-only.
8000
StephenHodgson
added
Breaking Change
Ready for review
PR finished primary development, open for review
labels
Apr 1, 2020
Removed Diagnostics Data Provider Profile #484
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FejZa
approved these changes
Apr 1, 2020
SimonDarksideJ
approved these changes
Apr 1, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XRTK - Mixed Reality Toolkit Change Request
Overview
There was an extra profile for diagnostics data providers but it wasn't needed and was breaking the configuration list for the diagnostics data providers. Solution was to remove it for now. If later on we need a
BaseDiagnosticsDataProviderProfilefor all of the variant profiles to use then we can add it at that time.Breaking Changes:
MixedRealityDataProviderProfile