8000 Decouple ledger from xrpld/app by a1q123456 · Pull Request #5492 · XRPLF/rippled · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Decouple ledger from xrpld/app #5492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Decouple ledger from xrpld/app #5492

wants to merge 4 commits into from
+160 −154

Conversation

a1q123456
Copy link
Collaborator

High Level Overview of Change

This PR decouples ledger from xrpld/app, and therefore fully clears the path to the modularisation of the ledger component.

Context of Change

Before this change, View.cpp relies on MPTokenAuthorize::authorize, and this change moves MPTokenAuthorize::authorize to View.cpp to invert the dependency, making ledger a standalone module.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Performance (increase or change in throughput and/or latency)
  • Tests (you added tests for code that already exists, or your new feature included in this PR)
  • Documentation update
  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • Release

API Impact

This change doesn't affect any API

  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)

Test Plan

As usual, regression test just for our sanity

Future Tasks

Modularise ledger

@a1q123456 a1q123456 marked this pull request as ready for review July 3, 2025 14:38
@a1q123456 a1q123456 changed the title [DRAFT] Decouple ledger from xrpld/app Decouple ledger from xrpld/app Jul 3, 2025
@a1q123456 a1q123456 requested a review from yinyiqian1 July 3, 2025 14:39
@codecov Codecov
Copy link
codecov bot commented Jul 3, 2025

Codecov Report

Attention: Patch coverage is 92.85714% with 5 lines in your changes missing coverage. Please review.

Project coverage is 79.1%. Comparing base (9874d47) to head (e9dfa61).

Files with missing lines Patch % Lines
src/xrpld/ledger/detail/View.cpp 92.5% 4 Missing ⚠️
src/xrpld/app/tx/detail/MPTokenAuthorize.cpp 83.3% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #5492     +/-   ##
=========================================
- Coverage     79.1%   79.1%   -0.0%     
=========================================
  Files          816     816             
  Lines        71622   71622             
  Branches      8237    8237             
=========================================
- Hits         56644   56643      -1     
- Misses       14978   14979      +1
Files with missing lines Coverage Δ
src/xrpld/app/tx/detail/MPTokenAuthorize.h 100.0% <ø> (ø)
src/xrpld/app/tx/detail/VaultDeposit.cpp 96.4% <100.0%> (ø)
src/xrpld/ledger/View.h 100.0% <ø> (ø)
src/xrpld/app/tx/detail/MPTokenAuthorize.cpp 96.3% <83.3%> (+0.9%) ⬆️
src/xrpld/ledger/detail/View.cpp 92.0% <92.5%> (-<0.1%) ⬇️

... and 6 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bronek Bronek Awaiting requested review from Bronek

@ximinez ximinez Awaiting requested review from ximinez

@vlntb vlntb Awaiting requested review from vlntb

@vvysokikh1 vvysokikh1 Awaiting requested review from vvysokikh1

@yinyiqian1 yinyiqian1 Awaiting requested review from yinyiqian1

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@a1q123456
0