Fix delegate test silently fail with batch #5476
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5476 +/- ##
=========================================
- Coverage 79.1% 79.1% -0.0%
=========================================
Files 817 817
Lines 71703 71703
Branches 8237 8240 +3
=========================================
- Hits 56721 56711 -10
- Misses 14982 14992 +10 see 3 files with indirect coverage changes 🚀 New features to boost your workflow:
|
src/test/app/Batch_test.cpp
Outdated
| tesSUCCESS, | ||
| batch::outer(gw, seq, batchFee, tfAllOrNothing), | ||
| batch::inner(jv1, seq + 1), | ||
| // tecNO_DELEGATE_PERMISSION: not authorized by the delegating |
There was a problem hiding this comment.
It's failing on the first not the second right?
I think using the tfIndependent flag is a better choice for these failing tests.
I realize all my tests used tfAllOrNothing but going forward I think its much easier to understand whats happening if we use tfIndependent and we can visualize the errors easier. So then both these results should be tecNO_DELEGATE_PERMISSION and they should be in the ledger.
There was a problem hiding this comment.
modified in ac6328386706383283b8154fba54862369793da0
|
EDIT: reviewed |
|
@yinyiqian1 is this ready to merge ? |
@Bronek Yes. It is ready. |
The test to make sure
tfInnerBatchTxnwon't block delegated transactions would silently fail inDelegate_test.cpp.This commit removes these cases from
Delegate_test.cpp. and adds them toBatch_test.cpp.This will not silently fail because we will explicitly check batch delegate result.
Moving to
Batch_test.cppto avoid refactoring too many helper functions.High Level Overview of Change
Context of Change
Type of Change
.gitignore, formatting, dropping support for older tooling)API Impact
libxrplchange (any change that may affectlibxrplor dependents oflibxrpl)