8000 Removed external project build cores division by vvysokikh1 · Pull Request #5475 · XRPLF/rippled · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Removed external project build cores division #5475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 5, 2025
Merged

Removed external project build cores division #5475

merged 2 commits into from
Jun 5, 2025

Conversation

vvysokikh1
Copy link
Collaborator
@vvysokikh1 vvysokikh1 commented Jun 5, 2025 •
edited by bthomee
Loading

High Level Overview of Change

Context of Change

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Performance (increase or change in throughput and/or latency)
  • Tests (you added tests for code that already exists, or your new feature included in this PR)
  • Documentation update
  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • Release

API Impact

  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)

@vvysokikh1 vvysokikh1 requested review from a1q123456 and bthomee June 5, 2025 11:17
@vvysokikh1 vvysokikh1 added the Trivial Simple change with minimal effect, or already tested. Only needs one approval. label Jun 5, 2025
@bthomee
Copy link
Collaborator
bthomee commented Jun 5, 2025

Looking at the CMake documentation regarding ProcessorCount, the way it's used here sets the ep_procs variable to the number of processors and, after halving it, then eventually only logs the variable value. It doesn't seem to actually be used anywhere; so this PR is helpful by removing unused code but doesn't affect the build in any way.

@codecov Codecov
Copy link
codecov bot commented Jun 5, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.1%. Comparing base (58c2c82) to head (2f3d885).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #5475     +/-   ##
=========================================
- Coverage     79.1%   79.1%   -0.0%     
=========================================
  Files          817     817             
  Lines        71697   71697             
  Branches      8236    8237      +1     
=========================================
- Hits         56713   56712      -1     
- Misses       14984   14985      +1

see 1 file with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bthomee bthomee enabled auto-merge (squash) June 5, 2025 13:07
@bthomee bthomee merged commit 8bf4a5c into develop Jun 5, 2025
28 checks passed
@bthomee bthomee deleted the vvysokikh1/remove_ep_core_divider branch June 5, 2025 13:37
This was referenced Jun 12, 2025
Merged
Closed
Closed
@legleux legleux mentioned this pull request Jun 23, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a1q123456 a1q123456 a1q123456 approved these changes

@bthomee bthomee bthomee approved these changes

Assignees
No one assigned
Labels
Trivial Simple change with minimal effect, or already tested. Only needs one approval.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vvysokikh1 @bthomee @a1q123456
0