chore[tests]: improve env.meta usage #5457
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5457 +/- ##
=======================================
Coverage 78.7% 78.7%
=======================================
Files 816 816
Lines 70542 70542
Branches 8284 8282 -2
=======================================
+ Hits 55494 55496 +2
+ Misses 15048 15046 -2 see 4 files with indirect coverage changes 🚀 New features to boost your workflow:
|
vvysokikh1
approved these changes
May 29, 2025
This was referenced Jun 12, 2025
Merged
Closed
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
This PR changes the ledger close in
env.metato be conditional on if it hasn't already been closed (i.e. the current ledger doesn't have any transactions in it).There is no source code change in this PR.
Context of Change
This makes it a bit easier to use, as it will still work if you close the ledger outside of this usage. Previously, if you accidentally closed the ledger outside of the
metafunction, it would segfault and it was incredibly difficult to debug.Type of Change
.gitignore, formatting, dropping support for older tooling)