8000 DRAFT: chore: Require Draft PRs to opt in to run CI with a label by ximinez · Pull Request #5401 · XRPLF/rippled · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

DRAFT: chore: Require Draft PRs to opt in to run CI with a label #5401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

DRAFT: chore: Require Draft PRs to opt in to run CI with a label #5401

wants to merge 5 commits into from

Conversation

ximinez
Copy link
Collaborator
@ximinez ximinez commented Apr 11, 2025 •
edited
Loading
  • Avoids costly overhead for idle PRs where the CI results don't add any
    value.

High Level Overview of Change

Context of Change

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Performance (increase or change in throughput and/or latency)
  • Tests (you added tests for code that already exists, or your new feature included in this PR)
  • Documentation update
  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • Release

API Impact

  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)

@ximinez
chore: Do not run CI jobs if "NoCI" flag is set
b1f446a 
- Avoids costly overhead for idle PRs where the CI results don't add any
  value.
@ximinez ximinez added the NoCI label Apr 11, 2025
@ximinez ximinez force-pushed the ximinez/disable_ci2 branch 7 times, most recently from 0907b94 to d62f8be Compare April 11, 2025 20:08
@ximinez ximinez marked this pull request as ready for review April 11, 2025 20:14
@ximinez ximinez force-pushed the ximinez/disable_ci2 branch from d62f8be to f97e49f Compare April 11, 2025 20:14
@ximinez ximinez marked this pull request as draft April 11, 2025 20:16
@ximinez ximinez force-pushed the ximinez/disable_ci2 branch 3 times, most recently from f5afb24 to 521d3a8 Compare April 11, 2025 20:50
@ximinez ximinez added DraftRunCI Normally CI does not run on draft PRs. This opts in. CI Continuous Integration Functionality labels Apr 11, 2025
@ximinez ximinez force-pushed the ximinez/disable_ci2 branch from 521d3a8 to c5664ce Compare April 11, 2025 20:58
@ximinez ximinez removed the DraftRunCI Normally CI does not run on draft PRs. This opts in. label Apr 11, 2025
@ximinez ximinez force-pushed the ximinez/disable_ci2 branch from c5664ce to c846b6e Compare April 11, 2025 21:03
@ximinez ximinez marked this pull request as ready for review April 11, 2025 21:20
@ximinez ximinez marked this pull request as draft April 11, 2025 21:20
@ximinez
Simplify conditions:
a393442 
- Run on push, non-draft PR, marked as ready for review, or if
  "DraftRunCI" label is set.
@ximinez ximinez mentioned this pull request Apr 11, 2025
Merged
1 task
@ximinez ximinez removed the NoCI label Apr 11, 2025
@ximinez ximinez changed the base branch from develop to ximinez/disable_ci April 11, 2025 21:44
Base automatically changed from ximinez/disable_ci to develop April 11, 2025 22:21
@ximinez ximinez closed this Apr 11, 2025
@ximinez ximinez deleted the ximinez/disable_ci2 branch April 11, 2025 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CI Continuous Integration Functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ximinez
0