8000 chore: Rename docs job by bthomee · Pull Request #5398 · XRPLF/rippled · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

chore: Rename docs job #5398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 27, 2025
Merged

chore: Rename docs job #5398

merged 3 commits into from
May 27, 2025

Conversation

bthomee
Copy link
Collaborator
@bthomee bthomee commented Apr 10, 2025

High Level Overview of Change

Renames the docs job from job to documentation for better readability, and makes it run on the shared runner.

Context of Change

We were pulling our Docker images from DockerHub without logging in, causing us to run into rate limits. To solve this, the images were pushed to our GitHub registry, but the documentation pipeline cannot access them as it runs on the GitHub runner instead of our own runner. This change makes the pipeline run on our shared runner.

As the documentation job name job is meaningless, this PR renames it to documentation.

Type of Change

  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)

@bthomee bthomee added the Trivial Simple change with minimal effect, or already tested. Only needs one approval. label Apr 10, 2025
Copy link
codecov bot commented Apr 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.6%. Comparing base (cd777f7) to head (a79a57e).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #5398     +/-   ##
=========================================
- Coverage     78.6%   78.6%   -0.0%     
=========================================
  Files          816     816             
  Lines        70505   70505             
  Branches      8288    8292      +4     
=========================================
- Hits         55447   55439      -8     
- Misses       15058   15066      +8     

see 4 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bthomee bthomee requested a review from legleux April 10, 2025 15:24
@bthomee bthomee marked this pull request as ready for review April 10, 2025 15:25
Copy link
Collaborator
@legleux legleux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't really see a need to use Ripple's runners for building docs. Otherwise seems fine.
documentation is better than job for sure.

@bthomee bthomee changed the title chore: Renames docs job and runs on shared runner chore: Renames docs job May 27, 2025
@bthomee bthomee enabled auto-merge (squash) May 27, 2025 19:24
@bthomee bthomee changed the title chore: Renames docs job chore: Rename docs job May 27, 2025
@bthomee bthomee disabled auto-merge May 27, 2025 19:24
@bthomee bthomee enabled auto-merge (squash) May 27, 2025 19:24
@bthomee bthomee merged commit cae5294 into develop May 27, 2025
28 checks passed
@bthomee bthomee deleted the bthomee/docs branch May 27, 2025 20:03
This was referenced Jun 12, 2025
@legleux legleux mentioned this pull request Jun 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Trivial Simple change with minimal effect, or already tested. Only needs one approval.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0