DRAFT: Optimize when to acquire ledgers from the network #5352
+265
−96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## ximinez/fix-getledger #5352 +/- ##
=======================================================
Coverage ? 77.9%
=======================================================
Files ? 796
Lines ? 68974
Branches ? 8419
=======================================================
Hits ? 53755
Misses ? 15219
Partials ? 0
🚀 New features to boost your workflow:
|
0e4f4d2 to
06e0540
Compare
06e0540 to
4b464d1
Compare
4b464d1 to
a6799ec
Compare
a6799ec to
0b8c2b3
Compare
0b8c2b3 to
f2b1a67
Compare
f2b1a67 to
c1215d0
Compare
c1215d0 to
966204c
Compare
966204c to
c49d81c
Compare
c49d81c to
07fa3a6
Compare
07fa3a6 to
12ce5d1
Compare
12ce5d1 to
a20a4c8
Compare
a20a4c8 to
9fdc610
Compare
9fdc610 to
9f481fe
Compare
9f481fe to
503ed03
Compare
503ed03 to
3a685d6
Compare
3a685d6 to
99fb808
Compare
99fb808 to
706a4c9
Compare
b92c9f9 to
15eeaff
Compare
15eeaff to
b402f06
Compare
b402f06 to
d7efe41
Compare
d7efe41 to
e75b993
Compare
e75b993 to
faac952
Compare
faac952 to
4d35847
Compare
3b03627 to
80a17a2
Compare
- Improve logging related to ledger acquisition and operating mode changes - Class "CanProcess" to keep track of processing of distinct items
- Drop duplicate outgoing TMGetLedger messages per peer
- Allow a retry after 30s in case of peer or network congestion.
- Addresses RIPD-1870
- (Changes levelization. That is not desirable, and will need to be fixed.)
- Drop duplicate incoming TMGetLedger messages per peer
- Allow a retry after 15s in case of peer or network congestion.
- The requestCookie is ignored when computing the hash, thus increasing
the chances of detecting duplicate messages.
- With duplicate messages, keep track of the different requestCookies
(or lack of cookie). When work is finally done for a given request,
send the response to all the peers that are waiting on the request,
sending one message per peer, including all the cookies and
a "directResponse" flag indicating the data is intended for the
sender, too.
- Addresses RIPD-1871
- Drop duplicate incoming TMLedgerData messages
- Addresses RIPD-1869
Particularly avoid acquiring ledgers likely to be produced locally very soon. Derived from XRPLF#4764 Co-authored-by: Mark Travis <mtravis@ripple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Context of Change
Type of Change
.gitignore, formatting, dropping support for older tooling)API Impact
libxrplchange (any change that may affectlibxrplor dependents oflibxrpl)