Update Conan dependencies: various #5349
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5349 +/- ##
=========================================
- Coverage 78.2% 78.1% -0.0%
=========================================
Files 795 795
Lines 68448 68447 -1
Branches 8273 8277 +4
=========================================
- Hits 53493 53484 -9
- Misses 14955 14963 +8 see 3 files with indirect coverage changes 🚀 New features to boost your workflow:
|
| @@ -90,6 +90,11 @@ set_target_properties(OpenSSL::SSL PROPERTIES | |||
| INTERFACE_COMPILE_DEFINITIONS OPENSSL_NO_SSL2 | |||
| ) | |||
| set(SECP256K1_INSTALL TRUE) | |||
| set(SECP256K1_BUILD_BENCHMARK OFF) | |||
There was a problem hiding this comment.
Since we (I) committed this (as a sin) we might as well turn it off at the source
| @@ -68,7 +68,7 @@ def requirements(self): | |||
| if self.options.with_mysql: | |||
| self.requires("libmysqlclient/8.1.0") | |||
| if self.options.with_postgresql: | |||
| self.requires("libpq/15.5") | |||
There was a problem hiding this comment.
I wouldn't update dependency's dependencies in external. The recipes are written for a specific version by someone else so why bother.
Update the dependency's dependency by updating the dependency.
There was a problem hiding this comment.
I thought we needed this for something?
Hmm, this reminds me of something I was seeing why I never approved this. #4431 (comment)
prevents builders from statically linking it.
I didn't see that before but that might explain it.
| @@ -32,6 +32,14 @@ jobs: | |||
| build_dir: .build | |||
| NUM_PROCESSORS: 12 | |||
| steps: | |||
| - name: cleanup | |||
There was a problem hiding this comment.
Probably don't have to worry about this anymore I guess.
Ok, once the Conan 2 changes have been merged we can create a new PR. |
High Level Overview of Change
This PR updates snappy, onetbb, zstd, zlib, and libpq. The snappy library has been removed from the
external/directory, as the latest version no longer needs our custom patches. In addition, building the optional secp256k1 binaries is turned off.Context of Change
Dependency scanning revealed that current dependencies are out of date. Updating dependencies allows us to take advantage of bug fixes, new features, and/or security improvements.
Type of Change