8000 TRIVIAL: Collapse some split log messages into one by ximinez · Pull Request #5347 · XRPLF/rippled · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

TRIVIAL: Collapse some split log messages into one #5347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 6, 2025
Merged

TRIVIAL: Collapse some split log messages into one #5347

merged 2 commits into from
Jun 6, 2025

Conversation

ximinez
Copy link
Collaborator
@ximinez ximinez commented Mar 13, 2025 •
edited
Loading

High Level Overview of Change

Multi-line log messages are hard to work with. Writing these handful of related messages as one message should make the log a tiny bit easier to manage.

Context of Change

Scratch an itch

Type of Change

  • Refactor (non-breaking change that only restructures code)

@ximinez ximinez force-pushed the ximinez/multilinelog branch from 5d71e28 to 566dffd Compare March 17, 2025 23:01
@codecov Codecov
Copy link
codecov bot commented Mar 17, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 79.1%. Comparing base (8bf4a5c) to head (c9a6bb7).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
src/xrpld/app/ledger/detail/InboundLedger.cpp 71.4% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #5347     +/-   ##
=========================================
- Coverage     79.1%   79.1%   -0.0%     
=========================================
  Files          817     817             
  Lines        71697   71700      +3     
  Branches      8240    8260     +20     
=========================================
- Hits         56706   56684     -22     
- Misses       14991   15016     +25
Files with missing lines Coverage Δ
src/xrpld/app/ledger/detail/InboundLedger.cpp 34.3% <71.4%> (-2.1%) ⬇️

... and 7 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ximinez ximinez force-pushed the ximinez/multilinelog branch 5 times, most recently from 0f7c41f to a6d1edb Compare March 25, 2025 16:12
@ximinez ximinez force-pushed the ximinez/multilinelog branch 3 times, most recently from 4340580 to ff218a1 Compare April 2, 2025 14:44
@ximinez ximinez force-pushed the ximinez/multilinelog branch 6 times, most recently from ad9051f to 64284d8 Compare April 10, 2025 21:40
@ximinez ximinez force-pushed the ximinez/multilinelog branch from 64284d8 to 1096c87 Compare April 11, 2025 22:29
@ximinez ximinez force-pushed the ximinez/multilinelog branch 3 times, most recently from 19de8b9 to fb4ab10 Compare April 30, 2025 13:59
@ximinez ximinez force-pushed the ximinez/multilinelog branch 2 times, most recently from da9fbbb to 934c71b Compare May 5, 2025 01:51
@ximinez
Collapse some split log messages into one
208d68e 
- Multi-line log messages are much harder to work with
@ximinez ximinez force-pushed the ximinez/multilinelog branch from 934c71b to 208d68e Compare May 14, 2025 15:01
@ximinez ximinez added Low Priority Trivial Simple change with minimal effect, or already tested. Only needs one approval. labels May 16, 2025
@ximinez ximinez marked this pull request as ready for review May 16, 2025 08:58
@ximinez ximinez changed the title DRAFT: Collapse some split log messages into one TRIVIAL: Collapse some split log messages into one May 16, 2025
@bthomee bthomee enabled auto-merge (squash) June 6, 2025 15:22
@bthomee bthomee merged commit d494bf4 into develop Jun 6, 2025
27 of 28 checks passed
@bthomee bthomee deleted the ximinez/multilinelog branch June 6, 2025 16:01
This was referenced Jun 12, 2025
Merged
Closed
Closed
@legleux legleux mentioned this pull request Jun 23, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bthomee bthomee bthomee approved these changes

Assignees
No one assigned
Labels
Low Priority Trivial Simple change with minimal effect, or already tested. Only needs one approval.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ximinez @bthomee
0