8000 Replace `assert` with `XRPL_ASSERT` by Bronek · Pull Request #5312 · XRPLF/rippled · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Replace assert with XRPL_ASSERT #5312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 25, 2025
Merged

Replace assert with XRPL_ASSERT #5312

merged 3 commits into from
Feb 25, 2025

Conversation

Bronek
Copy link
Collaborator
@Bronek Bronek commented Feb 24, 2025

High Level Overview of Change

Replace assert with XRPL_ASSERT in AmendmentTable.cpp

Context of Change

assert was added in #5173 ; during a merge from develop it should have been replaced by XRPL_ASSERT in that PR but it did not happen.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Performance (increase or change in throughput and/or latency)
  • Tests (you added tests for code that already exists, or your new feature included in this PR)
  • Documentation update
  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • Release

API Impact

  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)

@Bronek Bronek requested a review from ximinez February 24, 2025 14:09
@Bronek Bronek added the Trivial Simple change with minimal effect, or already tested. Only needs one approval. label Feb 24, 2025
@codecov Codecov
Copy link
codecov bot commented Feb 24, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 78.2%. Comparing base (9745718) to head (5d58d78).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
src/xrpld/app/misc/detail/AmendmentTable.cpp 66.7% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #5312   +/-   ##
=======================================
  Coverage     78.2%   78.2%           
=======================================
  Files          790     790           
  Lines        67739   67740    +1     
  Branches      8174    8174           
=======================================
+ Hits         52961   52963    +2     
+ Misses       14778   14777    -1
Files with missing lines Coverage Δ
src/xrpld/overlay/detail/PeerImp.cpp 3.8% <ø> (ø)
src/xrpld/overlay/detail/PeerImp.h 12.8% <ø> (ø)
src/xrpld/app/misc/detail/AmendmentTable.cpp 95.5% <66.7%> (ø)

... and 2 files with indirect coverage changes

Impacted file tree graph

@Bronek Bronek added the Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. label Feb 25, 2025
@bthomee bthomee merged commit 37d06bc into develop Feb 25, 2025
23 of 24 checks passed
@bthomee bthomee deleted the Bronek/fix_asserts branch February 25, 2025 16:43
@legleux legleux mentioned this pull request Feb 26, 2025
Closed
5 tasks
ximinez pushed a commit that referenced this pull request Feb 28, 2025
@Bronek @ximinez
Fix Replace assert with XRPL_ASSERT (#5312)
9fb1cba
This was referenced Mar 3, 2025
Merged
Closed
Closed
Merged
Tapanito pushed a commit to Tapanito/rippled that referenced this pull request Mar 24, 2025
@Bronek @Tapanito
Fix Replace assert with XRPL_ASSERT (XRPLF#5312)
0ddb832
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ximinez ximinez ximinez approved these changes

@bthomee bthomee bthomee approved these changes

Assignees
No one assigned
Labels
Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. Trivial Simple change with minimal effect, or already tested. Only needs one approval.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Bronek @ximinez @bthomee
0