Acquire previously failed transaction set from #5318
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
network as new proposal arrives.
bthomee
approved these changes
Feb 25, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5318 +/- ##
=======================================
Coverage 78.2% 78.2%
=======================================
Files 790 790
Lines 67740 67741 +1
Branches 8177 8173 -4
=======================================
+ Hits 52956 52965 +9
+ Misses 14784 14776 -8
... and 4 files with indirect coverage changes |
ximinez
approved these changes
Feb 25, 2025
There was a problem hiding this comment.
There are a couple of places in trigger where failed_ can be set if the received data is somehow incorrect. It might be worth clearing that data out if that happens. But I suspect that is very unlikely to be the case if we get a trusted proposal with it. Extra checking can be added later. This is a good start as-is.
ximinez
pushed a commit
that referenced
this pull request
Feb 28, 2025
…oposal arrives (#5318) Reset the failure variable.
This was referenced Mar 3, 2025
Merged
Closed
Closed
Merged
Tapanito
pushed a commit
to Tapanito/rippled
that referenced
this pull request
Mar 24, 2025
…oposal arrives (XRPLF#5318) Reset the failure variable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
network as new proposal arrives.
High Level Overview of Change
Clear failure flag to ensure that previously-failed inbound ledger gets acquired if a new trusted proposal arrives.
Context of Change
Type of Change
.gitignore, formatting, dropping support for older tooling)API Impact
libxrplchange (any change that may affectlibxrplor dependents oflibxrpl)