DRAFT: Reduce duplicate peer traffic for ledger data #5301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5301 +/- ##
=========================================
- Coverage 78.1% 77.9% -0.2%
=========================================
Files 795 796 +1
Lines 68598 68921 +323
Branches 8281 8441 +160
=========================================
+ Hits 53584 53668 +84
- Misses 15014 15253 +239
... and 5 files with indirect coverage changes 🚀 New features to boost your workflow:
|
73497e5 to
15e4475
Compare
8a1331c to
021c10d
Compare
46f8af5 to
0e4f4d2
Compare
0b8c2b3 to
f2b1a67
Compare
966204c to
c49d81c
Compare
503ed03 to
3a685d6
Compare
3a685d6 to
99fb808
Compare
706a4c9 to
3f71758
Compare
3f71758 to
b92c9f9
Compare
3 tasks
d7efe41 to
e75b993
Compare
faac952 to
4d35847
Compare
4d35847 to
3b03627
Compare
- Improve logging related to ledger acquisition and operating mode changes - Class "CanProcess" to keep track of processing of distinct items
- Drop duplicate outgoing TMGetLedger messages per peer
- Allow a retry after 30s in case of peer or network congestion.
- Addresses RIPD-1870
- (Changes levelization. That is not desirable, and will need to be fixed.)
- Drop duplicate incoming TMGetLedger messages per peer
- Allow a retry after 15s in case of peer or network congestion.
- The requestCookie is ignored when computing the hash, thus increasing
the chances of detecting duplicate messages.
- With duplicate messages, keep track of the different requestCookies
(or lack of cookie). When work is finally done for a given request,
send the response to all the peers that are waiting on the request,
sending one message per peer, including all the cookies and
a "directResponse" flag indicating the data is intended for the
sender, too.
- Addresses RIPD-1871
- Drop duplicate incoming TMLedgerData messages
- Addresses RIPD-1869
3b03627 to
80a17a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recreates the changes from #5126 (reverted in #5300), and the related bug fix once I find it.
High Level Overview of Change
Context of Change
Type of Change
.gitignore, formatting, dropping support for older tooling)API Impact
libxrplchange (any change that may affectlibxrplor dependents oflibxrpl)