8000 Updated build instructions for Ubuntu 22.04+ by vlntb · Pull Request #5292 · XRPLF/rippled · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
8000

Updated build instructions for Ubuntu 22.04+ #5292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 27, 2025
Merged

Updated build instructions for Ubuntu 22.04+ #5292

merged 2 commits into from
May 27, 2025

Conversation

vlntb
Copy link
Collaborator
@vlntb vlntb commented Feb 17, 2025 •
edited
Loading

High Level Overview of Change

Recent Debian-based distributions (i.e. Ubuntu 22.04+) now restrict direct modifications to the system Python. To use an isolated system-wide install, one should use the pipx tool.

Context of Change

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Performance (increase or change in throughput and/or latency)
  • Tests (you added tests for code that already exists, or your new feature included in this PR)
  • Documentation update
  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • Release

API Impact

  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking change 8000 s should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)

@vlntb vlntb changed the title updated build instructions for Ubuntu 22.04+ Updated build instructions for Ubuntu 22.04+ Feb 17, 2025
@vlntb vlntb added the Documentation README changes, code comments, etc. label Feb 17, 2025
@vlntb vlntb marked this pull request as ready for review February 17, 2025 15:59
@codecov Codecov
Copy link
codecov bot commented Feb 17, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.7%. Comparing base (2a61aee) to head (6bd077b).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #5292   +/-   ##
=======================================
  Coverage     78.6%   78.7%           
=======================================
  Files          816     816           
  Lines        70505   70506    +1     
  Branches      8288    8284    -4     
=======================================
+ Hits         55448   55453    +5     
+ Misses       15057   15053    -4

see 4 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vlntb vlntb added the Trivial Simple change with minimal effect, or already tested. Only needs one approval. label Feb 17, 2025
@bthomee bthomee requested a review from legleux February 17, 2025 16:10
legleux
legleux approved these changes Feb 19, 2025
View reviewed changes
Copy link
Collaborator
@legleux legleux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a reasonable suggestion for adding Conan globally.

@bthomee
Copy link
Collaborator
bthomee commented Mar 17, 2025

@vlntb Ready to merge?

@vlntb
Copy link
Collaborator Author
vlntb commented May 27, 2025

@vlntb Ready to merge?

Yes, this one can be merged

@bthomee bthomee enabled auto-merge (squash) May 27, 2025 17:54
@bthomee bthomee merged commit 8b9e21e into develop May 27, 2025
28 checks passed
@bthomee bthomee deleted the chore/update-build-instructions branch May 27, 2025 18:32
This was referenced Jun 12, 2025
Merged
Closed
Closed
@legleux legleux mentioned this pull request Jun 23, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@legleux legleux legleux approved these changes

Assignees
No one assigned
Labels
Documentation README changes, code comments, etc. Trivial Simple change with minimal effect, or already tested. Only needs one approval.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vlntb @bthomee @legleux
0