Switch Permissioned Domain to Supported::yes #5287
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvadari
approved these changes
Feb 12, 2025
3e7e13f to
ed9c892
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5287 +/- ##
=======================================
Coverage 77.9% 77.9%
=======================================
Files 791 791
Lines 68006 68007 +1
Branches 8348 8347 -1
=======================================
+ Hits 52964 52969 +5
+ Misses 15042 15038 -4 see 4 files with indirect coverage changes |
Bronek
approved these changes
Feb 15, 2025
This was referenced Feb 18, 2025
Closed
Closed
Closed
q73zhao
pushed a commit
that referenced
this pull request
Feb 24, 2025
Switch Permissioned Domain feature's supported flag from Supported::no to Supported::yes for it to be votable.
This was referenced Feb 26, 2025
Closed
Merged
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Switch Permissioned Domain to Supported::yes
Type of Change
Before / After
Switch Permissioned Domain feature's
supportedflag fromSupported::notoSupported::yes