Remove lambda from rotateWithLock
#5286
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
I would add levelization fix to this PR but the branch protection rules forbid me from adding any commits :-| |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## ximinez/db-lock #5286 +/- ##
=================================================
Coverage ? 78.2%
=================================================
Files ? 790
Lines ? 67634
Branches ? 8162
=================================================
Hits ? 52858
Misses ? 14776
Partials ? 0
|
|
Judging by comments in #3342 it seems that we do need both |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possible improvement to PR #5276
This is based on assumption that we do not need to call
clearCaches(validatedSeq)twice. There should be no reason to call it second time inside the critical section, just like there should be no reason to updatestate_db_inside the critical section, so this change minimises the critical section and also removes the risk that some untested code from outside ofDatabaseRotatingImpcould run inside it.