BUILD.md: ensure build_type and CMAKE_BUILD_TYPE match #5274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5274 +/- ##
=========================================
- Coverage 78.2% 78.2% -0.0%
=========================================
Files 790 790
Lines 67639 67638 -1
Branches 8162 8163 +1
=========================================
- Hits 52866 52863 -3
- Misses 14773 14775 +2 see 5 files with indirect coverage changes |
ximinez
requested changes
Feb 4, 2025
Co-authored-by: Ed Hennis <ed@ripple.com>
Bronek
approved these changes
Feb 6, 2025
ximinez
approved these changes
Feb 11, 2025
Co-authored-by: Ed Hennis <ed@ripple.com>
q73zhao
pushed a commit
that referenced
this pull request
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Running these will result in an error:
conan install .. --output-folder . --build missing --settings build_type=Debugcmake -DCMAKE_TOOLCHAIN_FILE:FILEPATH=build/generators/conan_toolchain.cmake -DCMAKE_BUILD_TYPE=Release -Dxrpld=ON -Dtests=ON ..cmake --build .The build instructions provided 2
conan installlines with different build_type settings, but the "obvious"cmakeline used only 1 of them.Context of Change
In addition to me, I have seen at least 2 other engineers run into this exact same error.
Type of Change
.gitignore, formatting, dropping support for older tooling)