8000 Reformat code with clang-format-18 by thejohnfreeman · Pull Request #5157 · XRPLF/rippled · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Reformat code with clang-format-18 #5157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 16, 2024
Merged

Reformat code with clang-format-18 #5157

merged 5 commits into from
Oct 16, 2024

Conversation

thejohnfreeman
Copy link
Contributor

This is a second attempt at reformatting our first-party sources with a newer version of clang-format. The first was #4938. That PR was created shortly before Ubuntu LTS 24.04 was released, and internally we decided to hold off on a flag commit like this until the new LTS was available in GitHub Actions, letting us easily update to an even newer version of clang-format (18 instead of 15). That day has come.

@thejohnfreeman thejohnfreeman marked this pull request as ready for review October 15, 2024 23:36
@codecov Codecov
Copy link
codecov bot commented Oct 15, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 68.58974% with 49 lines in your changes missing coverage. Please review.

Project coverage is 76.2%. Comparing base (bf4a7b6) to head (f0dabd1).
Report is 5 commits behind head on develop.

Files with missing lines Patch % Lines
src/xrpld/app/ledger/LedgerHistory.cpp 0.0% 28 Missing ⚠️
src/xrpld/app/tx/detail/Payment.cpp 50.0% 4 Missing ⚠️
src/xrpld/consensus/Consensus.h 25.0% 3 Missing ⚠️
src/xrpld/peerfinder/detail/Logic.h 0.0% 3 Missing ⚠️
src/libxrpl/beast/insight/NullCollector.cpp 50.0% 2 Missing ⚠️
src/xrpld/app/tx/detail/CancelOffer.cpp 50.0% 2 Missing ⚠️
src/xrpld/overlay/detail/PeerImp.cpp 0.0% 2 Missing ⚠️
include/xrpl/server/detail/BaseHTTPPeer.h 50.0% 1 Missing ⚠️
src/libxrpl/beast/utility/src/beast_Journal.cpp 50.0% 1 Missing ⚠️
src/xrpld/app/misc/detail/ValidatorList.cpp 0.0% 1 Missing ⚠️
... and 2 more
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #5157   +/-   ##
=======================================
  Coverage     76.2%   76.2%           
=======================================
  Files          760     760           
  Lines        61568   61557   -11     
  Branches      8126    8124    -2     
=======================================
- Hits         46898   46892    -6     
+ Misses       14670   14665    -5
Files with missing lines Coverage Δ
include/xrpl/basics/Expected.h 100.0% <100.0%> (ø)
include/xrpl/basics/FeeUnits.h 90.1% <100.0%> (ø)
include/xrpl/basics/IOUAmount.h 100.0% <100.0%> (ø)
include/xrpl/basics/Number.h 100.0% <ø> (ø)
include/xrpl/basics/XRPAmount.h 98.8% <100.0%> (ø)
include/xrpl/basics/base_uint.h 96.6% <100.0%> (ø)
include/xrpl/basics/safe_cast.h 81.8% <ø> (ø)
include/xrpl/basics/tagged_integer.h 100.0% <100.0%> (ø)
...pl/beast/container/detail/aged_ordered_container.h 97.2% <ø> (ø)
.../beast/container/detail/aged_unordered_container.h 96.1% <ø> (ø)
... and 52 more

Impacted file tree graph

@Bronek Bronek self-requested a review October 16, 2024 14:32
@thejohnfreeman thejohnfreeman merged commit f0dabd1 into XRPLF:develop Oct 16, 2024
19 of 20 checks passed
@intelliot intelliot added this to the 2.3.0 (October 2024) milestone Oct 16, 2024
@thejohnfreeman thejohnfreeman deleted the reformat branch October 16, 2024 17:43
@mvadari
Copy link
Collaborator
mvadari commented Oct 16, 2024

Confirmed that the pre-commit hook still works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bronek Bronek Bronek approved these changes

@vvysokikh1 vvysokikh1 vvysokikh1 approved these changes

@mvadari mvadari Awaiting requested review from mvadari

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Core Ledger
Status: ✅ Merged
Milestone
2.3.0
Development

Successfully merging this pull request may close these issues.
5 participants
@thejohnfreeman @mvadari @Bronek @vvysokikh1 @intelliot
0