8000 Batch (XLS-56) by dangell7 · Pull Request #5060 · XRPLF/rippled · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Batch (XLS-56) #5060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 114 commits into from
May 23, 2025
Merged

Batch (XLS-56) #5060

merged 114 commits into from
May 23, 2025

Conversation

dangell7
Copy link
Collaborator
@dangell7 dangell7 commented Jul 10, 2024 •
edited
Loading

High Level Overview of Change

XLS spec: https://github.com/XRPLF/XRPL-Standards/blob/master/XLS-0056d-batch/README.md

Context of Change

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Performance (increase or change in throughput and/or latency)
  • Tests (you added tests for code that already exists, or your new feature included in this PR)
  • Documentation update
  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • Release

API Impact

  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)

Test Plan

https://gist.github.com/dangell7/3afbe8c4597a58dc2b02be598f9b7d54

@codecov Codecov
Copy link
codecov bot commented Jul 10, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 94.05204% with 32 lines in your changes missing coverage. Please review.

Project coverage is 78.6%. Comparing base (40ce8a8) to head (66d5f27).
Report is 13 commits behind head on develop.

Files with missing lines Patch % Lines
src/xrpld/app/tx/detail/applySteps.cpp 28.6% 15 Missing ⚠️
src/libxrpl/protocol/STTx.cpp 92.0% 8 Missing ⚠️
src/xrpld/app/misc/NetworkOPs.cpp 87.0% 3 Missing ⚠️
src/xrpld/app/tx/detail/Transactor.cpp 95.7% 3 Missing ⚠️
src/xrpld/app/tx/detail/apply.cpp 96.7% 2 Missing ⚠️
src/xrpld/ledger/detail/OpenView.cpp 50.0% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #5060     +/-   ##
=========================================
+ Coverage     78.5%   78.6%   +0.1%     
=========================================
  Files          813     816      +3     
  Lines        70084   70505    +421     
  Branches      8283    8291      +8     
=========================================
+ Hits         55031   55439    +408     
- Misses       15053   15066     +13
Files with missing lines Coverage Δ
include/xrpl/protocol/Batch.h 100.0% <100.0%> (ø)
include/xrpl/protocol/HashPrefix.h 100.0% <ø> (ø)
include/xrpl/protocol/STTx.h 100.0% <ø> (ø)
include/xrpl/protocol/TER.h 100.0% <100.0%> (ø)
include/xrpl/protocol/TxMeta.h 93.8% <100.0%> (+2.1%) ⬆️
include/xrpl/protocol/detail/transactions.macro 100.0% <100.0%> (ø)
src/libxrpl/protocol/InnerObjectFormats.cpp 100.0% <100.0%> (ø)
src/libxrpl/protocol/TER.cpp 100.0% <ø> (ø)
src/libxrpl/protocol/TxMeta.cpp 96.5% <100.0%> (+0.3%) ⬆️
src/xrpld/app/ledger/detail/BuildLedger.cpp 91.9% <100.0%> (+0.5%) ⬆️
... and 24 more

... and 3 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

cindyyan317
cindyyan317 reviewed Jul 30, 2024
View reviewed changes
ximinez
ximinez reviewed Jul 31, 2024
View reviewed changes
@ximinez

This comment was marked as outdated.

Sign in to view
@dangell7 dangell7 marked this pull request as draft July 31, 2024 19:53
@tequdev

This comment was marked as resolved.

Sign in to view
@tequdev

This comment was marked as outdated.

Sign in to view
@tequdev

This comment was marked as outdated.

Sign in to view
@tequdev

This comment was marked as resolved.

Sign in to view
@dangell7

This comment was marked as resolved.

Sign in to view
@tequdev

This comment was marked as resolved.

Sign in to view
mvadari
mvadari reviewed Aug 20, 2024
View reviewed changes
@dangell7 dangell7 marked this pull request as ready for review September 10, 2024 23:29
@dangell7 dangell7 requested a review from ximinez September 24, 2024 06:43
@kennyzlei kennyzlei requested a review from shawnxie999 October 1, 2024 20:27
This was referenced Oct 7, 2024
Merged
Merged
shawnxie999

This comment was marked as resolved.

Sign in to view

shawnxie999

This comment was marked as resolved.

Sign in to view

mvadari
mvadari reviewed Oct 23, 2024
View reviewed changes
mvadari
mvadari reviewed Oct 23, 2024
View reviewed changes
mvadari
mvadari reviewed Oct 23, 2024
View reviewed changes
mvadari
mvadari reviewed Oct 23, 2024
View reviewed changes
mvadari
mvadari reviewed Oct 23, 2024
View reviewed changes
mvadari
mvadari reviewed Oct 23, 2024
View reviewed changes
mvadari
mvadari reviewed Oct 23, 2024
View reviewed changes
mvadari
mvadari reviewed Oct 23, 2024
View reviewed changes
mvadari
mvadari reviewed Oct 23, 2024
View reviewed changes
mvadari
mvadari reviewed Oct 23, 2024
View reviewed changes
mvadari
mvadari reviewed Oct 23, 2024
View reviewed changes
@dangell7 dangell7 changed the title Batch Amendment Batch (XLS-56) May 23, 2025
@mvadari mvadari added the Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. label May 23, 2025
@bthomee
Copy link
Collaborator
bthomee commented May 23, 2025

@dangell7 can you please update your branch?

@bthomee bthomee enabled auto-merge (squash) May 23, 2025 16:16
@bthomee bthomee disabled auto-merge May 23, 2025 16:16
@bthomee
Copy link
Collaborator
bthomee commented May 23, 2025

@XRPLF/rpc-reviewers can you please check and approve the RPC-related changes?

PeterChen13579
PeterChen13579 approved these changes May 23, 2025
View reviewed changes
Copy link
Contributor
@PeterChen13579 PeterChen13579 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

mvadari
mvadari reviewed May 23, 2025
View reviewed changes
@mvadari mvadari dismissed ckeshava’s stale review May 23, 2025 18:35

All the comments from the requested changes have been resolved

mvadari
mvadari reviewed May 23, 2025
View reviewed changes
@dangell7 dangell7 force-pushed the feature-batch branch 2 times, most recently from adb41ee to afa63ca Compare May 23, 2025 19:11
mvadari
mvadari reviewed May 23, 2025
View reviewed changes
@bthomee bthomee enabled auto-merge (squash) May 23, 2025 19:31
@bthomee bthomee merged commit 2a61aee into XRPLF:develop May 23, 2025
26 checks passed
@PeterChen13579 PeterChen13579 mentioned this pull request May 27, 2025
Closed
@VLEFF VLEFF mentioned this pull request Jun 2, 2025
Closed
@intelliot intelliot added Perf SignedOff RippleX Performance Team has approved and removed Perf Attn Needed Attention needed from RippleX Performance Team labels Jun 2, 2025
@Bronek Bronek mentioned this pull request Jun 5, 2025
Open
13 tasks
This was referenced Jun 12, 2025
Merged
Closed
Closed
@legleux legleux mentioned this pull request Jun 23, 2025
Merged
@pdp2121 pdp2121 mentioned this pull request Jun 26, 2025
Merged
8 tasks
pdp2121 added a commit to ripple/explorer that referenced this pull request Jul 2, 2025
@pdp2121
feat: Batch XLS-0056d support (#1199)
b6470b6 
## High Level Overview of Change

<!--
Please include a summary/list of the changes.
If too broad, please consider splitting into multiple PRs.
-->

Add support for Batch.

### Context of Change

<!--
Please include the context of a change.
If a bug fix, when was the bug introduced? What was the behavior?
If a new feature, why was this architecture chosen? What were the
alternatives?
If a refactor, how is this better than the previous implementation?

If there is a design document for this feature, please link it here.
-->
XRPLF/rippled#5060

### Type of Change

<!--
Please check relevant options, delete irrelevant ones.
-->

- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] Refactor (non-breaking change that only restructures code)
- [ ] Tests (You added tests for code that already exists, or your new
feature included in this PR)
- [ ] Documentation Updates
- [ ] Translation Updates
- [ ] Release

## Before / After

<!--
If just refactoring / back-end changes, this can be just an in-English
description of the change at a technical level.
If a UI change, screenshots should be included.
-->

### Simple

![localhost_3000_transactions_9B956A77943DF3FB891DD14D2D41A87CD6E5FA8CC606A097F47319EE6110ABA1_detailed](https://github.com/user-attachments/assets/fc4c3db8-6093-41a0-9e24-ee0c753df019)

### Details tab (Description)

![Screenshot 2025-07-01 at 12 32
09 PM](https://github.com/user-attachments/assets/b564ac6f-01af-42de-a706-e3faeaa9a484)

### TableDetail


![Screenshot 2025-07-01 at 12 32
42 PM](https://github.com/user-attachments/assets/9483eea4-251b-4be2-8eb6-93d17ae6c59b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bthomee bthomee bthomee left review comments

@cindyyan317 cindyyan317 cindyyan317 left review comments

@mvadari mvadari mvadari approved these changes

@PeterChen13579 PeterChen13579 PeterChen13579 approved these changes

@shawnxie999 shawnxie999 shawnxie999 approved these changes

@Speedtraders199 Speedtraders199 Speedtraders199 approved these changes

@ximinez ximinez Awaiting requested review from ximinez

@ckeshava ckeshava Awaiting requested review from ckeshava

Assignees
No one assigned
Labels
Amendment API Change Perf SignedOff RippleX Performance Team has approved Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. Tx Change
Projects
None yet
Milestone
2.5.0 (Q2 2025)
Development

Successfully merging this pull request may close these issues.
0