Add RPC "simulate" to execute a dry run of a transaction #5069
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5069 +/- ##
=========================================
+ Coverage 78.0% 78.1% +0.1%
=========================================
Files 789 790 +1
Lines 67061 67279 +218
Branches 8108 8101 -7
=========================================
+ Hits 52324 52562 +238
+ Misses 14737 14717 -20
... and 4 files with indirect coverage changes |
Bronek
approved these changes
Jan 28, 2025
Bronek
reviewed
Jan 28, 2025
Bronek
reviewed
Jan 28, 2025
oleks-rip
reviewed
Jan 28, 2025
Bronek
approved these changes
Jan 28, 2025
simulate RPC to dry-run a tx (XLS-69d)
This was referenced Feb 18, 2025
Closed
Closed
Closed
q73zhao
pushed a commit
that referenced
this pull request
Feb 24, 2025
- Spec: https://github.com/XRPLF/XRPL-Standards/tree/master/XLS-0069d-simulate - Also update signing methods to autofill fees better and properly handle transactions that require a non-standard fee.
This was referenced Feb 26, 2025
Closed
Merged
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
This PR adds a new API method, titled
simulate, which executes a dry run of a transaction submission.This PR also fixes #5070.
Context of Change
It is useful to take a transaction, simulate execution it in the current ledger, and return the metadata - but not persist the transaction in the ledger. This can be used for testing, analysis, and more.
XLS spec: XRPLF/XRPL-Standards#207
Type of Change
.gitignore, formatting, dropping support for older tooling)API Impact
libxrplchange (any change that may affectlibxrplor dependents oflibxrpl)Test Plan
Testing is still in progress. Unit tests are and will be added.
Current Status
This PR is complete and ready for review. You can build this branch and sync with the network of your choice (including Mainnet). The public is welcome to test and use this code (at your own risk). Next steps are code review and QA testing.