8000 feat: Add support for deep freeze by PeterChen13579 · Pull Request #1875 · XRPLF/clio · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: Add support for deep freeze #1875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 5, 2025
Merged

feat: Add support for deep freeze #1875

merged 6 commits into from
Mar 5, 2025

Conversation

PeterChen13579
Copy link
Collaborator

fixes #1826

PeterChen13579
PeterChen13579 commented Feb 5, 2025
View reviewed changes
Copy link
Collaborator Author
@PeterChen13579 PeterChen13579 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will be merged when new libxrpl which contains rippled deep freeze is merged.

cindyyan317
cindyyan317 reviewed Feb 5, 2025
View reviewed changes
cindyyan317
cindyyan317 suggested changes Feb 5, 2025 10000
View reviewed changes
Copy link
Contributor
@cindyyan317 cindyyan317 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding testcases 💚
Spot one logic mistake. Will continuing reviewing after fix.

cindyyan317
cindyyan317 reviewed Feb 6, 2025
View reviewed changes
cindyyan317
cindyyan317 reviewed Feb 6, 2025
View reviewed changes
cindyyan317
cindyyan317 reviewed Feb 6, 2025
View reviewed changes
cindyyan317
cindyyan317 reviewed Feb 6, 2025
View reviewed changes
cindyyan317
cindyyan317 reviewed Feb 6, 2025
View reviewed changes
cindyyan317
cindyyan317 reviewed Feb 6, 2025
View reviewed changes
cindyyan317
cindyyan317 previously approved these changes Feb 7, 2025
View reviewed changes
Copy link
Contributor
@cindyyan317 cindyyan317 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@codecov Codecov
Copy link
codecov bot commented Mar 5, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 83.33333% with 6 lines in your changes missing coverage. Please review.

Project coverage is 73.20%. Comparing base (427ba47) to head (f47d912).
Report is 24 commits behind head on develop.

Files with missing lines Patch % Lines
src/rpc/RPCHelpers.cpp 76.92% 1 Missing and 5 partials ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #1875      +/-   ##
===========================================
+ Coverage    72.71%   73.20%   +0.49%     
===========================================
  Files          333      337       +4     
  Lines        13525    13837     +312     
  Branches      6881     7018     +137     
===========================================
+ Hits          9835    10130     +295     
+ Misses        1785     1781       -4     
- Partials      1905     1926      +21

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PeterChen13579 PeterChen13579 merged commit 8a08c5e into XRPLF:develop Mar 5, 2025
22 checks passed
Sign up for free to 62C5 join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cindyyan317 cindyyan317 cindyyan317 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clio Support for Deep Freeze
2 participants
@PeterChen13579 @cindyyan317
0