This repository was archived by the owner on May 13, 2022. It is now read-only.
Edit career history #29
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…shed with a working prototype.
More robust than "" as it matches strings, and goes past the other checks in ::specs/url . Now the checks are ran and bad links rejected.
|
Hi Alex, please could you merge these conflicts? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#20
In order to allow the user to remove and add their cv files and/or links, I went for the simple overriding solution, which uses pre-existing functionality and graphql queries , just with empty values. Spec checks are preserved though , and the UI will not show empty strings as the subs handle that.
For a complete walkthrough on the development of the fixes in regards to this issue, the gist covering it all is just here