This repository was archived by the owner on Jan 17, 2025. It is now read-only.
include json packages #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
robbecker-wf
commented
Jul 30, 2023
| @@ -0,0 +1,13 @@ | |||
| name: json_annotation_3_1_1 | |||
There was a problem hiding this comment.
renamed the package. This is the only change to the json_annotation package.
robbecker-wf
commented
Jul 30, 2023
| @@ -0,0 +1,37 @@ | |||
| name: json_serializable_3_5_2 | |||
There was a problem hiding this comment.
renamed the package
robbecker-wf
commented
Jul 30, 2023
| hosted: | ||
| name: json_annotation_3_1_1 | ||
| url: https://pub.workiva.org | ||
| version: ^5.3.0 # This version doesn't matter, there's only the 3_1_1 forked version |
There was a problem hiding this comment.
changed the json_annotation dependency to the temporary copied name
robbecker-wf
commented
Jul 30, 2023
| WORKDIR /build/json_serializable-3.5.2 | ||
| RUN create_publishable_artifact.sh | ||
|
|
||
| ARG BUILD_ARTIFACTS_PUB=/build/dio/pub_package.pub.tgz:/build/json_annotation-3.1.1/pub_package.pub.tgz:/build/json_serializable-3.5.2/pub_package.pub.tgz |
There was a problem hiding this comment.
Add the new packages as build artifacts
dustinlessard-wf
approved these changes
Jul 31, 2023
|
QA+1 CI passes |
This was referenced Jul 31, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Include a straight copy of json_annotation at version 3.1.1, but renamed to json_annotation_3_1_1.
Include a straight copy of json_serializable at version 3.5.2, but with minor needed changes for Workiva
Testing