This repository was archived by the owner on Jan 28, 2023. It is now read-only.
rest api fixes #269
Merged
rest api fixes #269
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
god i hate github
god i hate github
JayWood
approved these changes
Mar 5, 2022
|
@jerzean PR looks good, can you confirm this has been tested locally or add some screenshots of a local test? |
havent tested locally, i dont have a website up atm, soon tho |
|
tested it via my mc server and seems to be working, granted i dont have a website so it cant run orders but i didnt touch anything in that part of the plugin |
|
Got it thanks, I'll test tomorrow at some point and get this build out. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General Checks
Place an X in the boxes that you have completed for this pull request.
PR Notes
Add some general notes here about what your PR solves for.
ping command edit to test outgoing connections to any website
fix restapi link, make getsiteurl public (so i didnt have to add in the extra checks for rest api links)