This repository was archived by the owner on Jan 28, 2023. It is now read-only.
Clarifies purpose of key #119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevents users from asking or stating that their key is empty.
|
@JayWood Wouldn't it be better to just re-write the code for generating keys? |
|
@TekkitCommando I dropped the key generation code as it was causing config issues. Server admins are used to editing configs ( or at least they should be ). |
|
Thanks @spannerman79 - I merged into dev-nighly. Hoping to release the multi-server support this coming sunday. |
|
No problems @JayWood - I should of noticed that there was a dev-nightly branch. My mistake. @TekkitCommando For a random string people can easily use https://www.random.org/strings/ - found with a literal 5 second google search. Anyone running a server should know how to edit config files. That is a given. |
|
@spannerman79 it was a matter of convenience but I get what Jay is saying. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents users from asking or stating that their key is empty.
Helps out to prevent issues like #118