Fix User Authentication Bug, Add Logging amd Modernised the Application #114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 19 commits
April 10, 2025 15:12
…file. Updated all dependencies to their latest stable versions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title: Fix User Authentication Bug and Add Logging
Description
This pull request addresses the following:
Motivation
The bug was causing invalid login attempts to bypass certain checks, leading to potential security issues. Logging was added to improve traceability and debugging in production.
Changes
AuthenticationService.javato fix the credential check logic.AuthLogger.javafor tracking login attempts.AuthenticationServiceTest.java.Testing
mvn testto ensure no regressions.Checklist
Bug fixed in authentication logic.
Logging implemented.
Unit tests updated.
Code reviewed for adherence to style guidelines.