8000 docs: explain conventional commit in contribute.md by 0yi0 · Pull Request #268 · WasmEdge/docs · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

docs: explain conventional commit in contribute.md #268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 5, 2025
Merged

docs: explain conventional commit in contribute.md #268

merged 1 commit into from
May 5, 2025

Conversation

0yi0
Copy link
Collaborator
@0yi0 0yi0 commented May 5, 2025 •
edited
Loading

Explanation

WasmEdge/WasmEdge#3850 introduced conventional commit.

Related issue

N/A

What type of PR is this

/kind documentation

@0yi0 0yi0 requested review from hydai, juntao and alabulei1 as code owners May 5, 2025 10:03
@juntao Flows.network Integration
Copy link
Member
juntao commented May 5, 2025 •
edited
Loading

Hello, I am a PR summary agent on flows.network. Here are my reviews of code commits in this PR.

Commit 3c82ae587aca0327585f75d7845a7a9f4fa96c19

-### Key Changes:

  1. Commit Format Section Added: Detailed explanation of Conventional Commit format added under the Commit Format section.
  2. Example Commit Messages Provided: Included examples of valid commit messages following the Conventional Commit guidelines.
  3. Allowed <type> Values Noted: Referenced allowed <type> values from @commitlint/@config-conventional.
  4. Enforcement Date Mentioned: Noted that WasmEdge has enforced conventional commits starting April 9, 2025.
  5. Reformatted Existing Content: Changed "Sign Your Commits" to "Commit Format" and reorganized content under this new section.
  6. Updated DCO Section: Moved the DCO (Developer Certificate of Origin) explanation to be a subsection within the Commit Format section.
  7. Example Commit Message Correction: Corrected example commit messages to follow Conventional Commit format in both the text and notes.

@0yi0 0yi0 marked this pull request as draft May 5, 2025 10:21
@0yi0
docs: explain conventional commit in contribute.md
3c82ae5 
Signed-off-by: Yi Huang <yi@secondstate.io>
@0yi0 0yi0 marked this pull request as ready for review May 5, 2025 10:26
@0yi0
Copy link
Collaborator Author
0yi0 commented May 5, 2025

Fixed format errors in the previous commit.

@hydai hydai merged commit a24e98c into WasmEdge:main May 5, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hydai hydai hydai approved these changes

@juntao juntao Awaiting requested review from juntao juntao is a code owner

@alabulei1 alabulei1 Awaiting requested review from alabulei1 alabulei1 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0yi0 @juntao @hydai
0