8000 Fix issue with bulk encoding of a large number of files by githubmicrob · Pull Request #555 · WWBN/AVideo-Encoder · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix issue with bulk encoding of a large number of files #555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 1, 2025
Merged

Fix issue with bulk encoding of a large number of files #555

merged 1 commit into from
May 1, 2025

Conversation

githubmicrob
Copy link
Contributor
@githubmicrob githubmicrob commented May 1, 2025 •
edited
Loading

The issue was caused by sending multiple XHR requests simultaneously, which led to some requests failing to enqueue files.
I considered the following solutions:

  1. Send a single XHR request for all files
  2. Send XHR requests sequentially
  3. Reduce the scope of the session lock
  4. Tune the lock acquisition retry count

This PR implements solution 3. While it mitigates the issue, a complete solution is more complex and will require further changes.

Fix: #554

Screenshot:
Screenshot from 2025-05-01 12-21-07

@DanielnetoDotCom DanielnetoDotCom merged commit 74e26ba into WWBN:master May 1, 2025
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue with Bulk Encode of large number of files
2 participants
@githubmicrob @DanielnetoDotCom
0