8000 Replace Sparsity detection by j-fu · Pull Request #203 · WIAS-PDELib/VoronoiFVM.jl · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Replace Sparsity detection #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 16, 2025
Merged

Replace Sparsity detection #203

merged 5 commits into from
Apr 16, 2025

Conversation

j-fu
Copy link
Member
@j-fu j-fu commented Apr 16, 2025 •
edited
Loading
  • No changes in core functionality
  • Replace Symbolics + SparseDiffTools by DifferentiationInterface + SparseConnectivityTracer + SparseMatrixColoring
  • Thus at once get rid of dependencies (SparseDiffTools) which probably will not be updated to ForwardDiff 1.0
  • Affected: generic operator + measurement_derivative + Example430
  • Breaking: remove possibility to provide own sparsity pattern - Performance of SparseConnectivityTracer is good enough now. Could be reintroduced if needed

@j-fu
Replace Sparsity detection
1a178d1 
- No changes in core functionality
- Replace Symbolics + SparseDiffTools by
  DifferentiationInterface + SparseConnectivityTracer + SparseMatrixColoring
- Thus at once get rid of dependencies (SparseDiffTools) which probably will
  not be updated to ForwardDiff 1.0
- Affected: generic operator + measurement_derivative + Example430
- Breaking: remove possibility to provide own sparsity pattern - Performance
  of SparseConnectivityTracer is good enough now. Could be reintroduced if needed
@j-fu
Copy link
Member Author
j-fu commented Apr 16, 2025 •
edited
Loading

This probably goes into 3.0 2.10

8000

See alsp JuliaDiff/DifferentiationInterface.jl#774

@j-fu j-fu mentioned this pull request Apr 16, 2025
Open
14 tasks
gdalle
gdalle suggested changes Apr 16, 2025
View reviewed changes
j-fu added 4 commits April 16, 2025 18:34
@j-fu
Move generic_matrix to SystemState
643e1cb 
Remove type assumptions on AD backend and jacobian_prep
(losing type stability in System which is however not very critical
and should be addressed in another PR)
@j-fu
Re-establish case with given generic operator sparsity
e2a29d9 
Remove buggy generic_operator_sparsity! call, sparsity is set via physics.
@j-fu
Changelog + version bump
c3ff950
@j-fu
fix docs env
c0bf59f
@j-fu j-fu mentioned this pull request Apr 16, 2025
Open
@gdalle
Copy link
gdalle commented Apr 16, 2025

Just insisting on the risks of relying on internal types: #203 (comment)

@j-fu j-fu merged commit da1ab9f into master Apr 16, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gdalle gdalle gdalle requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@j-fu @gdalle
3190
0