8000 Error refactoring by In-line · Pull Request #6 · Vrtgs/thirtyfour · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Error refactoring #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 22, 2020
Merged

Error refactoring #6

merged 2 commits into from
Apr 22, 2020

Conversation

In-line
Copy link
Contributor
@In-line In-line commented Apr 22, 2020

No description provided.

In-line added 2 commits April 22, 2020 12:10
@In-line
Implement std::error::Error for WebDriverError
f4f0296 
Refactor WebDriverError so it can provide underlying cause of the error.
Remove user error handling from "unreachable" cases, where it is assumed that error can't ever happen
@In-line
Run cargo fmt
79eb180
stevepryde
stevepryde approved these changes Apr 22, 2020
View reviewed changes
Copy link
Collaborator
@stevepryde stevepryde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thank you!

@stevepryde
Copy link
Collaborator

Travis build passed - not sure why it didn't update here:
https://travis-ci.org/github/stevepryde/thirtyfour/builds/678060582

@stevepryde stevepryde merged commit 9e713a3 into Vrtgs:master Apr 22, 2020
Vrtgs added a commit that referenced this pull request Aug 29, 2024
@Vrtgs
v0.33.1, fix #6
5f5a6f7 
Signed-off-by: Vrtgs <mirza123.the.best@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevepryde stevepryde stevepryde approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@In-line @stevepryde
0