VST-2898: Update license activation logic and add logging #2901
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: Enhanced error handling with logging for exceptions during activation.
vc-ci
reviewed
Mar 14, 2025
vc-ci
reviewed
Mar 14, 2025
Ljutyj
reviewed
Mar 14, 2025
| { | ||
| var activationUrl = new Uri(_platformOptions.LicenseActivationUrl + activationCode); | ||
| var httpResponse = await httpClient.GetAsync(activationUrl); | ||
| using (var httpClient = new HttpClient()) |
There was a problem hiding this comment.
If we make a refactoring It'll be better not to use the constructor for HttpClient. Instead of it .ner core has IHttpClientFactory or opportunity to inject IHttpClient to the constructor (needs also to declare the class via AddHttpClient in IColletionServices ) for better performance.
vc-ci
reviewed
Mar 17, 2025
vc-ci
reviewed
Mar 18, 2025
artem-dudarev
approved these changes
Mar 18, 2025
|
vc-ci
reviewed
Mar 18, 2025
Ljutyj
approved these changes
Mar 18, 2025
OlegoO
added a commit
that referenced
this pull request
Mar 18, 2025
OlegoO
added a commit
that referenced
this pull request
Mar 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix: Enhanced error handling with logging for exceptions during activation.
References
QA-test:
Jira-link:
https://virtocommerce.atlassian.net/browse/VCST-2898
Artifact URL:
Image tag:
ghcr.io/VirtoCommerce/platform:3.882.0-pr-2901-305f-vcst-2898-305fb3c1