8000 Fix for Darwin when pthread_threadid_np is unavailable by barracuda156 · Pull Request #97 · Viskores/viskores · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix for Darwin when pthread_threadid_np is unavailable #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 22, 2025
Merged

Fix for Darwin when pthread_threadid_np is unavailable #97

merged 3 commits into from
May 22, 2025

Conversation

barracuda156
Copy link
Contributor

Submitted to loguru upstream in emilk/loguru#276

@vicentebolea
Copy link
Collaborator

@barracuda156 we have a third-party repository for of loguru at https://gitlab.kitware.com/third-party/loguru where we store the Viskores branded loguru fork. I will submit this changes there as soon as the pass CI here.

@barracuda156
Copy link
Contributor Author

@vicentebolea Thank you!

@vicentebolea vicentebolea force-pushed the apple branch 2 times, most recently from fe89c31 to 46642a7 Compare May 20, 2025 23:46
@vicentebolea
Copy link
Collaborator

@barracuda156 ready! I took the liberty to take the bits from your PR to upstream

@kmorel
Copy link
Collaborator
kmorel commented May 21, 2025

@vicentebolea I see that posts to CDash are still failing (and causing all the CI to fail). I know you said that updates to CDash may cause it to go up and down, but it has not been working for us for several days. In that time, it looks like CI from ParaView has been able to submit to CDash (e.g., https://gitlab.kitware.com/paraview/paraview/-/jobs/11189434). Is something specifically broken for us that needs to be fixed?

@vicentebolea
Copy link
Collaborator

@vicentebolea I see that posts to CDash are still failing (and causing all the CI to fail). I know you said that updates to CDash may cause it to go up and down, but it has not been working for us for several days. In that time, it looks like CI from ParaView has been able to submit to CDash (e.g., https://gitlab.kitware.com/paraview/paraview/-/jobs/11189434). Is something specifically broken for us that needs to be fixed?

I have escalated this issue internally, it appears that this broke during a change of database provider that they did last week.

vicentebolea and others added 3 commits May 21, 2025 17:46
@vicentebolea
loguru: update tag
6d79c62
@kwrobot @vicentebolea
loguru 2025-05-20 (939586a6)
bcbae0b 
Code extracted from:

    https://gitlab.kitware.com/third-party/loguru.git

at commit 939586a6df8328722c09df3e018cf043c3303605 (for/viskores-20250520).
@vicentebolea
Merge branch 'upstream-loguru' into apple
56fc914 
# By Loguru Upstream
* upstream-loguru:
  loguru 2025-05-20 (939586a6)
@vicentebolea
Copy link
Collaborator

@kmorel #103 fixed the CDASH issue, rebasing PR will bring the fix to the existing PRs.

@vicentebolea vicentebolea enabled auto-merge May 21, 2025 21:47
@vicentebolea vicentebolea disabled auto-merge May 22, 2025 00:38
@vicentebolea vicentebolea enabled auto-merge May 22, 2025 00:38
@vicentebolea vicentebolea merged commit 6ae113e into Viskores:main May 22, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vicentebolea vicentebolea < 556C /a> vicentebolea approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@barracuda156 @vicentebolea @kmorel @kwrobot
0