8000 Chase down UnitTestStreamlineMPI_mpi error by kmorel · Pull Request #64 · Viskores/viskores · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Chase down UnitTestStreamlineMPI_mpi error #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Chase down UnitTestStreamlineMPI_mpi error #64

wants to merge 1 commit into from

Conversation

kmorel
Copy link
Collaborator
@kmorel kmorel commented Apr 16, 2025

No description provided.

@kmorel kmorel marked this pull request as draft April 16, 2025 23:14
@vicentebolea
Copy link
Collaborator

@kmorel we need to mark this as no draft for the Frank CI to run

@kmorel kmorel marked this pull request as ready for review April 19, 2025 18:57
@kmorel
Copy link
Collaborator Author
kmorel commented Apr 19, 2025

we need to mark this as no draft for the Frank CI to run

OK. Draft marking removed.

Is there a rational for this, or is this just the way things work?

@vicentebolea
Copy link
Collaborator

Is there a rational for this, or is this just the way things work?

I think that the reason for it to exist is that sometimes we might want to open a PR for the sake of a discussion but not using the precious CI. I can see how this might be useful in very large project with limited CI resources such as Spack.

In any case, it does not really makes sense to have it enabled in Viskores at this moment, fortunately this is a optional feature of the script that can be turned off. I will follow up with this change.
8000

@kmorel kmorel marked this pull request as draft May 7, 2025 22:05
@kmorel
Copy link
Collaborator Author
kmorel commented May 29, 2025

Here is an example of where the test seems to fail:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kmorel @vicentebolea
0