feat: update vutils/vscale version to support custom callback in tick… #1378
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xile611
reviewed
Aug 15, 2024
| import type { Point, TextContent } from '../core/type'; | ||
| import type { SegmentAttributes } from '../segment'; | ||
| import type { TagAttributes } from '../tag'; | ||
| import type { BaseScale } from '@visactor/vscale/es/base-scale'; |
xile611
reviewed
Aug 15, 2024
| @@ -75,5 +75,6 @@ | |||
| 8000 | }, | ||
| "publishConfig": { | |||
| "access": "public" | |||
| } | |||
| }, | |||
| "packageManager": "pnpm@9.4.0+sha512.f549b8a52c9d2b8536762f99c0722205efc5af913e77835dbccc3b0b0b2ca9e7dc8022b78062c17291c48e88749c70ce88eb5a74f1fa8c4bf5e18bb46c8bd83a" | |||
There was a problem hiding this comment.
这个是不是因为直接用了pnpm 安装依赖，我们现在是 rush update 更新依赖
rush底层用的也是pnpm
There was a problem hiding this comment.
嗯，跑jest的时候用了pnpm命令导致的
xile611
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add function callback options in tickmode to support custom ticks such as wilkson etc.
Can use customTicks with function in @visactor/vscale such as
wilkinsonExtendedfunction.(Related PR:VisActor/VUtil#198)🔗 Related issue link
🐞 Bugserver case id
💡 Background and solution
📝 Changelog
☑️ Self-Check before Merge
🚀 Summary
copilot:summary
🔍 Walkthrough
copilot:walkthrough