8000 feat: add `barGap` option for histogram chart by LonelySnowman · Pull Request #3967 · VisActor/VChart · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: add barGap option for histogram chart #3967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
May 29, 2025
Merged

feat: add barGap option for histogram chart #3967

merged 7 commits into from
May 29, 2025

Conversation

LonelySnowman
Copy link
Contributor
@LonelySnowman LonelySnowman commented May 15, 2025 •
edited
Loading

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Refactoring
  • Update dependency
  • Code style optimization
  • Test Case
  • Branch merge
  • Release
  • Site / documentation update
  • Demo update
  • Workflow
  • Other (about what?)

🔗 Related issue link

Close #2629

🔗 Related PR link

None

🐞 Bugserver case id

None

💡 Background and solution

Add barGap option for histogram chart.

📝 Changelog

Language Changelog
🇺🇸 English Add barGap option for histogram chart
🇨🇳 Chinese 为直方图添加 barGap 属性

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

copilot:summary

🔍 Walkthrough

copilot:walkthrough

@LonelySnowman
Copy link
Contributor Author

#3048 之前 PR 的 badcase 都测试过。

X 轴反向

image

添加最小宽度保护

image

水平堆叠直方图

image

基础直方图

image

< 8000 p class="ml-1 mb-2 mt-2" data-show-on-error hidden> Sorry, something went wrong.

@xuefei1313
Copy link
Contributor

参考一下之前一个学生的pr，里面提到了一些case
#3048
主要验证以下几个场景：
轴反转
最小宽度
还有参数名称，改为 barGap 吧

@LonelySnowman
Copy link
Contributor Author

@xuefei1313 轴反转 最小宽度 这两个 case 我验证过了，上面的评论有截图。参数名称从 barPadding 改为了 barGap。CI 流程 Bug Server CI / build 的报错应该不是我这个 PR 引入的，size limit 的 CI 我感觉要调高一点。

xiaoluoHe
xiaoluoHe reviewed May 27, 2025
View reviewed changes
@xiaoluoHe
Copy link
Contributor

跑一下 rush change，补充一下发布日志

@xiaoluoHe xiaoluoHe mentioned this pull request May 27, 2025
Open
20 tasks
xiaoluoHe
xiaoluoHe reviewed May 27, 2025
View reviewed changes
xiaoluoHe
xiaoluoHe reviewed May 27, 2025
View reviewed changes
@github-actions github-actions bot added the chore label May 28, 2025
@LonelySnowman LonelySnowman changed the title feat: linear bar add barpadding option feat: add barGap option for histogram chart May 29, 2025
@xiaoluoHe xiaoluoHe merged commit eac8c45 into VisActor:develop May 29, 2025
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiaoluoHe xiaoluoHe xiaoluoHe approved these changes

Assignees
No one assigned
Labels
chore docs typescript vchart
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] histogram support barPadding
3 participants
@LonelySnowman @xuefei1313 @xiaoluoHe
0