8000 Feat/convert data to position by kkxxkk2019 · Pull Request #200 · VisActor/VChart · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Feat/convert data to position #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 18, 2023
Merged

Feat/convert data to position #200

merged 5 commits into from
Jul 18, 2023

Conversation

kkxxkk2019
Copy link
Collaborator
@kkxxkk2019 kkxxkk2019 commented Jul 14, 2023 •
edited
Loading

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Refactoring
  • Update dependency
  • Code style optimization
  • Test Case
  • Branch merge
  • Release
  • Site / documentation update
  • Demo update
  • Workflow
  • Other (about what?)

🔗 Related issue link

close https://github.com/orgs/VisActor/projects/15/views/11?layout=table&pane=issue&itemId=32867841

🐞 Bugserver case id

💡 Background and solution

// usage
 vchart.convertDatumToPosition({
        State: 'WY',
        年龄段: '小于5岁',
        人口数量: 25635
      })
export type DataLinkSeries = {
  /**
   * 关联的系列 id
   */
  seriesId?: StringOrNumber;
  /**
   * 关联的系列索引
   */
  seriesIndex?: number;
};


/**
   * Convert the data to coordinate position
   * @param datum the datum to convert
   * @param dataLinkInfo the data link info, could be seriesId or seriesIndex, default is { seriesIndex: 0 }
   * @returns
   */
  convertDatumToPosition: (datum: Datum, dataLinkInfo?: DataLinkSeries) => IPoint | null;

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

copilot:summary

🔍 Walkthrough

copilot:walkthrough

@kkxxkk2019 kkxxkk2019 requested a review from xuefei1313 July 14, 2023 01:51
@kkxxkk2019 kkxxkk2019 added this to the v1.1.0 milestone Jul 14, 2023
xuefei1313
xuefei1313 reviewed Jul 18, 2023
View reviewed changes
@kkxxkk2019 kkxxkk2019 force-pushed the feat/convertDataToPosition branch from 9a5861d to 075d289 Compare July 18, 2023 07:11
@kkxxkk2019 kkxxkk2019 merged commit d4608df into develop Jul 18, 2023
@kkxxkk2019 kkxxkk2019 deleted the feat/convertDataToPosition branch July 18, 2023 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xuefei1313 xuefei1313 xuefei1313 approved these changes

Assignees
No one assigned
Labels
chore jest typescript vchart
Projects
None yet
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@kkxxkk2019 @xuefei1313
0