8000 refactor: refactor parser of `markByName` and `markByType` in theme by xile611 · Pull Request #2948 · VisActor/VChart · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

refactor: refactor parser of markByName and markByType in theme #2948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 15, 2024
Merged

refactor: refactor parser of markByName and markByType in theme #2948

merged 1 commit into from
Jul 15, 2024

Conversation

xile611
Copy link
Contributor
@xile611 xile611 commented Jul 15, 2024

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Refactoring
  • Update dependency
  • Code style optimization
  • Test Case
  • Branch merge
  • Release
  • Site / documentation update
  • Demo update
  • Workflow
  • Other (about what?)

🔗 Related issue link

🔗 Related PR link

🐞 Bugserver case id

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

copilot:summary

🔍 Walkthrough

copilot:walkthrough

@xile611 xile611 added this to the 1.12.0 milestone Jul 15, 2024
@xile611 xile611 changed the base branch from develop to dev/1.12.0 July 15, 2024 06:19
@xile611 xile611 force-pushed the refactor/theme-mark-parser branch from 2e0ccf7 to 555ae16 Compare July 15, 2024 06:19
@xile611 xile611 requested a review from xiaoluoHe July 15, 2024 06:20
@xile611 xile611 force-pushed the refactor/theme-mark-parser branch from 555ae16 to ffbf065 Compare July 15, 2024 06:22
@xile611 xile611 merged commit a2027ee into dev/1.12.0 Jul 15, 2024
4 of 6 checks passed
@xile611 xile611 deleted the refactor/theme-mark-parser branch July 15, 2024 09:48
@YuvrajKaushal YuvrajKaushal mentioned this pull request Sep 30, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiaoluoHe xiaoluoHe xiaoluoHe approved these changes

Assignees
No one assigned
Labels
typescript vchart
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.
2 participants
@xile611 @xiaoluoHe
0