8000 feat: optimize legend pager color in dark theme by xiaoluoHe · Pull Request #2825 · VisActor/VChart · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: optimize legend pager color in dark theme #2825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 19, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"changes": [
{
"packageName": "@visactor/vchart",
"comment": "fix: optimize discrete legend pager color in dark theme, related #2654",
"type": "none"
}
],
"packageName": "@visactor/vchart"
}
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,21 @@ export const discreteLegend: IDiscreteLegendTheme = {
},
space: 12
},
pager: {
textStyle: {
fill: { type: 'palette', key: 'discreteLegendPagerTextColor' }
},
handler: {
style: {
fill: { type: 'palette', key: 'discreteLegendPagerHandlerColor' }
},
state: {
disable: {
fill: { type: 'palette', key: 'discreteLegendPagerHandlerDisableColor' }
}
}
}
},
item: {
visible: true,
spaceCol: 10,
Expand Down
9 changes: 8 additions & 1 deletion packages/vchart/src/theme/builtin/dark/color-scheme.ts
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,14 @@ export const colorScheme: IThemeColorScheme = {
/** 成功色 */
successColor: '#14b267',
/** 信息色 */
infoColor: '#4284ff'
infoColor: '#4284ff',

/** 图例翻页器文字颜色 */
discreteLegendPagerTextColor: '#BBBDC3',
/** 图例翻页器按钮颜色 */
discreteLegendPagerHandlerColor: '#BBBDC3',
/** 图例翻页器按钮颜色(disable 态) */
discreteLegendPagerHandlerDisableColor: '#55595F'
} as BuiltinColorPalette
}
};
9 changes: 8 additions & 1 deletion packages/vchart/src/theme/builtin/light/color-scheme.ts
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,14 @@ export const colorScheme: IThemeColorScheme = {
/** 成功色 */
successColor: '#07a35a',
/** 信息色 */
infoColor: '#3073f2'
infoColor: '#3073f2',

/** 图例翻页器文字颜色 */
discreteLegendPagerTextColor: 'rgb(51, 51, 51)',
/** 图例翻页器按钮颜色 */
discreteLegendPagerHandlerColor: 'rgb(47, 69, 84)',
/** 图例翻页器按钮颜色(disable 态) */
discreteLegendPagerHandlerDisableColor: 'rgb(170, 170, 170)'
} as BuiltinColorPalette
}
};
Loading
0