8000 docs: add a map with flying lines demo by FunctionEurus · Pull Request #2714 · VisActor/VChart · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

docs: add a map with flying lines demo #2714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
May 28, 2024
Merged

docs: add a map with flying lines demo #2714

merged 14 commits into from
May 28, 2024

Conversation

FunctionEurus
Copy link
Contributor

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Refactoring
  • Update dependency
  • Code style optimization
  • Test Case
  • Branch merge
  • Release
  • Site / documentation update
  • Demo update
  • Workflow
  • Other (about what?)

🔗 Related issue link

implement #2660

🔗 Related PR link

🐞 Bugserver case id

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

copilot:summary

🔍 Walkthrough

copilot:walkthrough

@github-actions github-actions bot added the docs label May 20, 2024
@xile611 xile611 requested a review from xiaoluoHe May 20, 2024 09:52
xiaoluoHe
xiaoluoHe reviewed May 23, 2024
View reviewed changes
@xiaoluoHe xiaoluoHe linked an issue May 23, 2024 that may be closed by this pull request
[Demo] add demo of map chart with flying lines #2660
Closed
@FunctionEurus
Copy link
Contributor Author
FunctionEurus commented May 24, 2024 via email

@xiaoluoHe
Copy link
Contributor
xiaoluoHe commented May 24, 2024 •
edited
Loading

抱歉，之前的评论，我编辑时不小心删除了。
另外，还有几个 review 评论，辛苦看一下

@FunctionEurus
Copy link
Contributor Author

抱歉，之前的评论，我编辑时不小心删除了。 另外，还有几个 review 评论，辛苦看一下

好的！不过review评论我只找到不要出现中文这个，已经解决了

@xiaoluoHe
Copy link
Contributor

好的！不过review评论我只找到不要出现中文这个，已经解决了

@FunctionEurus 向上翻一下 pr conversation
image

xiaoluoHe
xiaoluoHe approved these changes May 27, 2024
View reviewed changes
@FunctionEurus
Copy link
Contributor Author

@xiaoluoHe 感谢您的截图，截图中的问题均已在新的commit中修正。不过还是很抱歉，我还是只能找到不要出现中文的review comment，而且也没有收到github的邮件推送，不知道是不是权限问题之类导致的
cannotfindcomment.png

@xiaoluoHe xiaoluoHe merged commit de8e030 into VisActor:develop May 28, 2024
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiaoluoHe xiaoluoHe xiaoluoHe approved these changes

Assignees
No one assigned
Labels
docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Demo] add demo of map chart with flying lines
2 participants
@FunctionEurus @xiaoluoHe
0