8000 Fix/range column spec by xile611 · Pull Request #2631 · VisActor/VChart · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix/range column spec #2631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 7, 2024
Merged

Fix/range column spec #2631

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8e9ab3f
fix: fix range-column-chart spec
xile611 May 7, 2024
c8d83dd
docs: update changlog of rush
xile611 May 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions common/changes/@visactor/vchart/develop_2024-05-07-04-11.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"comment": "fix: fix range-column-chart spec\n\n",
"type": "none",
"packageName": "@visactor/vchart"
}
],
"packageName": "@visactor/vchart",
"email": "dingling112@gmail.com"
}
6 changes: 5 additions & 1 deletion packages/vchart/src/chart/range-column/range-column-transformer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,13 @@ export class RangeColumnChartSpecTransformer<
protected _getDefaultSeriesSpec(spec: T): any {
const series: any = {
...super._getDefaultSeriesSpec(spec),
barWidth: (spec as IRangeColumnChartSpec).barWidth,
barMaxWidth: (spec as IRangeColumnChartSpec).barMaxWidth,
barMinWidth: (spec as IRangeColumnChartSpec).barMinWidth,
barGapInGroup: (spec as IRangeColumnChartSpec).barGapInGroup,
barBackground: (spec as IRangeColumnChartSpec).barBackground,
barMinHeight: (spec as IRangeColumnChartSpec).barMinHeight
barMinHeight: (spec as IRangeColumnChartSpec).barMinHeight,
stackCornerRadius: (spec as IRangeColumnChartSpec).stackCornerRadius
};
series.bar = spec.bar;
if (spec.direction === Direction.horizontal) {
Expand Down
0