8000 feat(vchart): support `renderFinished` and `animationEnd` event for vchart by kkxxkk2019 · Pull Request #240 · VisActor/VChart · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(vchart): support renderFinished and animationEnd event for vchart #240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 28, 2023
Merged

feat(vchart): support renderFinished and animationEnd event for vchart #240

merged 6 commits into from
Jul 28, 2023

Conversation

kkxxkk2019
Copy link
Collaborator
@kkxxkk2019 kkxxkk2019 commented Jul 20, 2023 •
edited
Loading

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Refactoring
  • Update dependency
  • Code style optimization
  • Test Case
  • Branch merge
  • Release
  • Site / documentation update
  • Demo update
  • Workflow
  • Other (about what?)

🔗 Related issue link

VisActor/VGrammar#72

🔗 Related PR link

🐞 Bugserver case id

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

copilot:summary

🔍 Walkthrough

copilot:walkthrough

@kkxxkk2019 kkxxkk2019 requested a review from xile611 July 20, 2023 08:14
@kkxxkk2019 kkxxkk2019 linked an issue Jul 20, 2023 that may be closed by this pull request
[Feature] add finished chart event #211
Closed
@github-actions github-actions bot added the chore label Jul 21, 2023
@kkxxkk2019 kkxxkk2019 changed the title WIP: feat(vchart): support renderFinished event for vchart WIP: feat(vchart): support renderFinished and animationEnd event for vchart Jul 21, 2023
@kkxxkk2019 kkxxkk2019 added this to the v1.2.0 milestone Jul 25, 2023
@kkxxkk2019 kkxxkk2019 force-pushed the feat/finished-event branch from 0e6d281 to 06c522d Compare July 26, 2023 09:36
@kkxxkk2019 kkxxkk2019 changed the title WIP: feat(vchart): support renderFinished and animationEnd event for vchart feat(vchart): support renderFinished and animationEnd event for vchart Jul 26, 2023
@kkxxkk2019 kkxxkk2019 changed the base branch from develop to dev/1.2.0 July 26, 2023 09:37
@kkxxkk2019 kkxxkk2019 force-pushed the feat/finished-event branch from 25c82ba to f278f88 Compare July 27, 2023 13:05
@kkxxkk2019 kkxxkk2019 requested a review from a team July 27, 2023 13:13
@kkxxkk2019 kkxxkk2019 merged commit 2252bc7 into dev/1.2.0 Jul 28, 2023
@kkxxkk2019 kkxxkk2019 deleted the feat/finished-event branch July 28, 2023 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiaoluoHe xiaoluoHe xiaoluoHe approved these changes

@xuefei1313 xuefei1313 xuefei1313 approved these changes

@xile611 xile611 Awaiting requested review from xile611

Assignees
No one assigned
Labels
chore react-vchart vchart
Projects
None yet
Milestone
v1.2.0
Development

Successfully merging this pull request may close these issues.

[Feature] add finished chart event
3 participants
@kkxxkk2019 @xiaoluoHe @xuefei1313
0