8000 Feat/point sampling 1.6.0 by skie1997 · Pull Request #1324 · VisActor/VChart · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Feat/point sampling 1.6.0 #1324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Nov 2, 2023
Merged

Feat/point sampling 1.6.0 #1324

merged 14 commits into from
Nov 2, 2023

Conversation

skie1997
Copy link
Contributor
@skie1997 skie1997 commented Oct 26, 2023 •
edited
Loading

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Refactoring
  • Update dependency
  • Code style optimization
  • Test Case
  • Branch merge
  • Release
  • Site / documentation update
  • Demo update
  • Workflow
  • Other (about what?)

🔗 Related issue link

close #460

🔗 Related PR link

VisActor/VGrammar#225

🐞 Bugserver case id

65395f4b159a621b655d9ff1
65395ee3159a621b655d9ff0
654244300dc4c5635dc0d9e4

💡 Background and solution

新增功能：

  • 折线图、柱状图 数据采样
  • 折线图point mark 防重叠

实现思路：
1、数据采样：

2、图元防重叠：依赖vGrammar的mark transform，type：'markoverlap'

  • 在line series 中自定义compiler逻辑, 通过this._symbolMark.getProduct().transform()为数据注入transform

image
image

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

copilot:summary

🔍 Walkthrough

copilot:walkthrough

@kkxxkk2019 kkxxkk2019 added this to the v1.6.0 milestone Oct 26, 2023
@kkxxkk2019
Copy link
Collaborator

冲突解决下

xiaoluoHe
xiaoluoHe reviewed Oct 31, 2023
View reviewed changes
xiaoluoHe
xiaoluoHe reviewed Oct 31, 2023
View reviewed changes
kkxxkk2019
kkxxkk2019 reviewed Oct 31, 2023
View reviewed changes
@kkxxkk2019 kkxxkk2019 merged commit d5f1740 into dev/1.6.0 Nov 2, 2023
@kkxxkk2019 kkxxkk2019 deleted the feat/point-sampling-1.6.0 branch November 2, 2023 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiaoluoHe xiaoluoHe xiaoluoHe left review comments

@kkxxkk2019 kkxxkk2019 kkxxkk2019 approved these changes

Assignees
No one assigned
Labels
chore docs typescript vchart
Projects
None yet
Milestone
v1.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@skie1997 @kkxxkk2019 @xiaoluoHe
0