8000 Feat/functional animation option by xiaoluoHe · Pull Request #1315 · VisActor/VChart · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Feat/functional animation option #1315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Nov 2, 2023

Conversation

xiaoluoHe
Copy link
Contributor

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Refactoring
  • Update dependency
  • Code style optimization
  • Test Case
  • Branch merge
  • Release
  • Site / documentation update
  • Demo update
  • Workflow
  • Other (about what?)

🔗 Related issue link

close #1205
close #1203

🔗 Related PR link

🐞 Bugserver case id

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

copilot:summary

🔍 Walkthrough

copilot:walkthrough

@kkxxkk2019
Copy link
Collaborator

冲突解决下~

return false;
}

if (morphConfig?.enable === false) {
const appearAnimationEnabled = (spec.animationAppear?.[markName] ?? spec.animationAppear) !== false;
const updateAnimationEnabled = (spec.animationAppear?.[markName] ?? spec.animationAppear) !== false;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

animationUpdate?

@xiaoluoHe xiaoluoHe force-pushed the feat/functional_animation_option branch from 206316a to 5d13e05 Compare November 1, 2023 11:35
@kkxxkk2019 kkxxkk2019 merged commit b4fd129 into dev/1.6.0 Nov 2, 2023
@kkxxkk2019 kkxxkk2019 deleted the feat/functional_animation_option branch November 2, 2023 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0