10000 fix(vchart): fix the duplicate event registration in scrollbar, fixed… by kkxxkk2019 · Pull Request #1246 · VisActor/VChart · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(vchart): fix the duplicate event registration in scrollbar, fixed… #1246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

kkxxkk2019
Copy link
Collaborator

🤔 This is a ...

  • New feature
  • Bug fix
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Refactoring
  • Update dependency
  • Code style optimization
  • Test Case
  • Branch merge
  • Release
  • Site / documentation update
  • Demo update
  • Workflow
  • Other (about what?)

🔗 Related issue link

closed #1241

🔗 Related PR link

🐞 Bugserver case id

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

copilot:summary

🔍 Walkthrough

copilot:walkthrough

@kkxxkk2019 kkxxkk2019 requested a review from skie1997 October 19, 2023 06:31
@kkxxkk2019 kkxxkk2019 added this to the v1.5.1 milestone Oct 19, 2023
@@ -104,7 +104,14 @@ export class ScrollBar<T extends IScrollBarSpec = IScrollBarSpec> extends DataFi
direction: this._isHorizontal ? 'horizontal' : 'vertical',
...this._getComponentAttrs()
});

// 绑定事件,防抖,防止频繁触发
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

升级vrender-components之后支持配置防抖和节流。也可以先合入,我在我的MR里再去掉

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK~

@kkxxkk2019 kkxxkk2019 merged commit c65977f into dev/1.5.0 Oct 19, 2023
@kkxxkk2019 kkxxkk2019 deleted the fix/issue-1214 branch October 19, 2023 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0