Support --stdin-display-name and the mixed style of files and stdin #278
Conversation
119e70b to
5d405e5
Compare
README.rst
Outdated
| @@ -122,6 +122,40 @@ You can configure linting severity, max errors, ... as following: | |||
|
|
|||
| $ vint --color --style ~/.vimrc | |||
|
|
|||
| And you can see all available options by `--help` as following: | |||
There was a problem hiding this comment.
Better:
You can see all available options by using
--help:
README.rst
Outdated
| --enable-neovim enable Neovim syntax | ||
| -f FORMAT, --format FORMAT | ||
| set output format | ||
| --stdin-alt-path STDIN_ALT_PATH |
There was a problem hiding this comment.
I do not find that name good.
What about --stdin-display-name? (used by flake8)
There was a problem hiding this comment.
I feel --stdin-display-name is a good name. Fixed at 7b718a5.
test/asserting/policy.py
Outdated
| assert actual_violation['level'] == expected_violation['level'] | ||
| self.assertEqual(actual_violation['name'], expected_violation['name']) | ||
| self.assertEqual(actual_violation['position'], expected_violation['position']) | ||
| self.assertEqual(actual_violation['level'], expected_violation['level']) |
There was a problem hiding this comment.
Why?
Aren't we using pytest here?
There was a problem hiding this comment.
The reason why I remove py.test specific code is the learning cost and the d 10000 ebugging cost. I felt that keep time for implementation shorter was important because I had only few moments to implement it.
In this case, I forget sometimes how to use py.test, so the tests got failures by my mistakes. But understanding what the error messages meant and how to fix it were not easy to me. I think the reason why the error message is hard is that py.test using some magics to implement the parameterized testing feature.
But I do not mean py.test is unuseful for all situation. Only this case, I determined that py.test is unnecessary for me. Feel free to use py.test if using py.test is quick way to acheve what you want.
I'm sorry about that. I was in hurry, so I could not separate changes.
The reason is DRY. I found the following smells:
There are 2 differences for each pair. The first one is what a file path is used. The second one is how to get the file content. We can unify the methods if we implement a new abstraction that encapsulate what a file path is holding and how to get the file content. This abstraction is Additionally, I implemented |
41056d4 to
037b270
Compare
Support
--stdin-display-nameand mixed style linting such asvint a.vim - b.vim(in commented at #240).