8000 Prepare to become ProhibitUnusedVariable to default-enabled by Kuniwak · Pull Request #275 · Vimjas/vint · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Prepare to become ProhibitUnusedVariable to default-enabled #275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 36 commits into from
Jun 29, 2018
Merged

Prepare to become ProhibitUnusedVariable to default-enabled #275

merged 36 commits into from
Jun 29, 2018

Conversation

Kuniwak
Copy link
Member
@Kuniwak Kuniwak commented Jun 17, 2018 •
edited
Loading

Fix the following three false positives:

function! s:foo() abort
    let x = 'x'
    let y = l:{x}  " The first false positive.
    echo y
endfunction

call call('s:foo', [])  " The second false positive.
call function('s:foo')  " The third false positive.

And support a ignored_patterns option for ProhibitUnusedVariable to manually disable the policy by name.
This is an example for the option:

---
policies:
  ProhibitUnusedVariable:
    enabled: yes
    ignored_patterns:
      - '^_+$'
      - '^s:_vital_loaded$'
      - '^s:_vital_depends$'

And also support line comment configuration that affect only the same line:

" vint: next-line -ProhibitUnusedVariable
let s:foobar = 'x'
echo s:{'foo' . 'bar'}

And also support scope analysis for lambdas.

@Kuniwak Kuniwak self-assigned this Jun 17, 2018
@Kuniwak Kuniwak force-pushed the inspect-vital-bugs branch from e26f5f2 to ed7c1f8 Compare June 17, 2018 20:50
@Kuniwak Kuniwak changed the title WIP: Enable ProhibitUnusedVariable Enable ProhibitUnusedVariable Jun 17, 2018
@Kuniwak Kuniwak changed the title Enable ProhibitUnusedVariable Prepare to become ProhibitUnusedVariable to default-enabled Jun 17, 2018
@Kuniwak Kuniwak force-pushed the inspect-vital-bugs branch 2 times, most recently from 330c0b8 to 362e91c Compare June 18, 2018 08:21
Kuniwak added 24 commits June 18, 2018 19:13
@Kuniwak
Upgrade Vital.vim
e95e16f
@Kuniwak
Refactor scope_plugin internal
ad04d6b
@Kuniwak
Add a test for #274
74f8d8d
@Kuniwak
Visit into NodeType.CURLYNAMEEXPR
e7037d9
@Kuniwak
NodeType.CURLYNAME should be classified as dynamic
10000
f743cd5
@Kuniwak
Refactor IdentifierClassifier internal
0542793
@Kuniwak
Rename the fixture for #274 to prepare for a test for
2dc106d
@Kuniwak
Analyze NodeType.CALL for call or function when the first arg is …
906c815 
…NodeType.STRING
@Kuniwak
fixup! Add a test for #274
1163051
@Kuniwak
Refactor scope_plugin internal
2eeef48
@Kuniwak
Fix false positives that is referenced at #274 comments
59855e0
@Kuniwak
Support ignored patterns for ProhibitUnusedVariable
82a7e11
@Kuniwak
Fix a typo
90a79e6
@Kuniwak
"..." should be not reported by ProhibitUnusedVariable
7f10972
@Kuniwak
Initial implementation for line config comments
ac2acca
@Kuniwak
Add a test for README
231cb9e
@Kuniwak
Better debugging
20449c2
@Kuniwak
fixup! Initial implementation for line config comments
b3c1968
@Kuniwak
fixup! Add a test for README
658fabb
@Kuniwak
Fix order of plugins
c51b54e
@Kuniwak
Keep disabled
90190ce
@Kuniwak
Update README.rst
8512688
10000
@Kuniwak
Fix tests
7fdf959
@Kuniwak
Change line config comment to next line config comment
24fdd4c
@Kuniwak Kuniwak force-pushed the inspect-vital-bugs branch from 362e91c to 24fdd4c Compare June 18, 2018 10:13
@Kuniwak Kuniwak force-pushed the inspect-vital-bugs branch from 29a5bba to 1cc2915 Compare June 19, 2018 20:33
@Kuniwak Kuniwak force-pushed the inspect-vital-bugs branch from a8fcd9a to fcee68a Compare June 19, 2018 20:48 8632
@Kuniwak Kuniwak mentioned this pull request Jun 19, 2018
Merged
@Kuniwak Kuniwak merged commit efff450 into master Jun 29, 2018
@Kuniwak Kuniwak deleted the inspect-vital-bugs branch June 29, 2018 03:10
@Kuniwak Kuniwak mentioned this pull request Jun 29, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Kuniwak Kuniwak

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Kuniwak
0